From: Jeff Law <law@redhat.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][calls.c] Remove #ifdef checks on STACK_GROWS_DOWNWARD
Date: Mon, 18 May 2015 14:57:00 -0000 [thread overview]
Message-ID: <5559FD7F.9070803@redhat.com> (raw)
In-Reply-To: <5559AF44.7010901@foss.arm.com>
On 05/18/2015 03:22 AM, Kyrill Tkachov wrote:
> Hi all,
>
> As per https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01166.html
> I saw that STACK_GROWS_DOWNWARD is being checked for ifdef in a number
> of places
> unrelated to the patch in the PR, so decided to remove the ifdef checks
> for STACK_GROWS_DOWNWARD
> in a separate patch. It's fairly mechanical.
>
> Bootstrapped on x86_64 and aarch64 and tested on arm.
> I believe these patches are considered obvious, so I'll commit this in a
> day, unless someone objects,
> before proceeding with the changes in
> https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01166.html
>
> 2015-05-18 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * calls.c: Always define STACK_GROWS_DOWNWARD as 0 or 1.
> (mem_overlaps_already_clobbered_arg_p): Rewrite ifdef
> STACK_GROWS_DOWNWARD as normal if.
> (expand_call): Likewise.
Thanks for taking care of this...
jeff
prev parent reply other threads:[~2015-05-18 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 9:25 Kyrill Tkachov
2015-05-18 14:57 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5559FD7F.9070803@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).