From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107687 invoked by alias); 18 May 2015 14:56:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107678 invoked by uid 89); 18 May 2015 14:56:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 18 May 2015 14:56:02 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4IEu0xo016008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 18 May 2015 10:56:00 -0400 Received: from localhost.localdomain (ovpn-113-21.phx2.redhat.com [10.3.113.21]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4IEtx07007121; Mon, 18 May 2015 10:55:59 -0400 Message-ID: <5559FD7F.9070803@redhat.com> Date: Mon, 18 May 2015 14:57:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Kyrill Tkachov , GCC Patches Subject: Re: [PATCH][calls.c] Remove #ifdef checks on STACK_GROWS_DOWNWARD References: <5559AF44.7010901@foss.arm.com> In-Reply-To: <5559AF44.7010901@foss.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg01576.txt.bz2 On 05/18/2015 03:22 AM, Kyrill Tkachov wrote: > Hi all, > > As per https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01166.html > I saw that STACK_GROWS_DOWNWARD is being checked for ifdef in a number > of places > unrelated to the patch in the PR, so decided to remove the ifdef checks > for STACK_GROWS_DOWNWARD > in a separate patch. It's fairly mechanical. > > Bootstrapped on x86_64 and aarch64 and tested on arm. > I believe these patches are considered obvious, so I'll commit this in a > day, unless someone objects, > before proceeding with the changes in > https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01166.html > > 2015-05-18 Kyrylo Tkachov > > * calls.c: Always define STACK_GROWS_DOWNWARD as 0 or 1. > (mem_overlaps_already_clobbered_arg_p): Rewrite ifdef > STACK_GROWS_DOWNWARD as normal if. > (expand_call): Likewise. Thanks for taking care of this... jeff