From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: miter_base simplification
Date: Tue, 19 May 2015 20:47:00 -0000 [thread overview]
Message-ID: <555BA09A.2050600@gmail.com> (raw)
In-Reply-To: <554682C7.7030409@gmail.com>
On 03/05/2015 22:19, François Dumont wrote:
> On 30/04/2015 13:18, Jonathan Wakely wrote:
>> On 30/04/15 10:40 +0200, François Dumont wrote:
>>> On 27/04/2015 13:55, Jonathan Wakely wrote:
>>>> (Alternatively, could the same simplification be made for
>>>> __miter_base? Do we need _Miter_base<> or just two overloads of
>>>> __miter_base()?)
>>>
>>> Definitely, I already have a patch for that.
>>
>> Great :-)
>
> And here is the patch for this part.
>
> I have implemented it in such a way that it will also remove several
> layers of move_iterator.
>
> 2015-05-04 François Dumont <fdumont@gcc.gnu.org>
>
> * include/bits/cpp_type_traits.h
> (std::move_iterator): Delete declaration.
> (std::__is_move_iterator<move_iterator>): Move partial
> specialization...
> * include/bits/stl_iterator.h: ... here.
> (std::__miter_base): Overloads for std::reverse_iterator and
> std::move_iterator.
> * include/bits/stl_algobase.h (std::__miter_base): Provide default
> implementation.
>
> Tested under Linux x86_64.
>
> Ok to commit ?
Is it ok ?
François
next prev parent reply other threads:[~2015-05-19 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 20:10 niter_base simplification François Dumont
2015-04-27 11:55 ` Jonathan Wakely
2015-04-30 9:00 ` François Dumont
2015-04-30 11:29 ` Jonathan Wakely
2015-05-03 20:19 ` miter_base simplification François Dumont
2015-05-19 20:47 ` François Dumont [this message]
2015-05-20 10:04 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555BA09A.2050600@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).