From: Jason Merrill <jason@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>,
Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch 3/10] debug-early merge: C++ front-end
Date: Wed, 20 May 2015 19:45:00 -0000 [thread overview]
Message-ID: <555CDDF4.2@redhat.com> (raw)
In-Reply-To: <554D5F75.6080901@redhat.com>
On 05/08/2015 09:14 PM, Aldy Hernandez wrote:
> + if (!flag_syntax_only)
> + c_parse_final_cleanups ();
The condition is a significant change of behavior for the C++ front end;
doing final instantiation and such even with -fsyntax-only was a
deliberate choice. Can we drop the condition?
> + timevar_stop (TV_PHASE_PARSING);
> + timevar_start (TV_PHASE_DBGINFO);
>
> perform_deferred_noexcept_checks ();
The only debug info stuff that was here has been removed, so there's no
longer any need to switch to a debug timevar. I think we should stay in
DEFERRED for the whole function.
Jason
WARNING: multiple messages have this Message-ID
From: Jason Merrill <jason@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch 3/10] debug-early merge: C++ front-end
Date: Wed, 20 May 2015 19:47:00 -0000 [thread overview]
Message-ID: <555CDDF4.2@redhat.com> (raw)
Message-ID: <20150520194700.0j8Y_AvA0DuGaJNdo4I1xTADjsU4BobHOLYDth8T_lQ@z> (raw)
In-Reply-To: <554D5F75.6080901@redhat.com>
On 05/08/2015 09:14 PM, Aldy Hernandez wrote:
> + if (!flag_syntax_only)
> + c_parse_final_cleanups ();
The condition is a significant change of behavior for the C++ front end;
doing final instantiation and such even with -fsyntax-only was a
deliberate choice. Can we drop the condition?
> + timevar_stop (TV_PHASE_PARSING);
> + timevar_start (TV_PHASE_DBGINFO);
>
> perform_deferred_noexcept_checks ();
The only debug info stuff that was here has been removed, so there's no
longer any need to switch to a debug timevar. I think we should stay in
DEFERRED for the whole function.
Jason
next prev parent reply other threads:[~2015-05-20 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 0:34 Aldy Hernandez
2015-05-08 11:57 ` Richard Biener
2015-05-08 18:48 ` Aldy Hernandez
2015-05-08 19:20 ` Richard Biener
2015-05-09 1:14 ` Aldy Hernandez
2015-05-20 19:45 ` Jason Merrill [this message]
2015-05-20 19:47 ` Jason Merrill
2015-05-20 21:45 ` Aldy Hernandez
2015-05-21 2:04 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555CDDF4.2@redhat.com \
--to=jason@redhat.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).