From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-398441-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 105117 invoked by alias); 20 May 2015 20:30:43 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 105102 invoked by uid 89); 20 May 2015 20:30:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 May 2015 20:30:40 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (Postfix) with ESMTPS id A85DC5F;	Wed, 20 May 2015 20:30:39 +0000 (UTC)
Received: from localhost.localdomain (ovpn-113-34.phx2.redhat.com [10.3.113.34])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4KKUcTw020870;	Wed, 20 May 2015 16:30:38 -0400
Message-ID: <555CEEEE.50902@redhat.com>
Date: Wed, 20 May 2015 20:40:00 -0000
From: Jeff Law <law@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Andreas Tobler <andreast-list@fgznet.ch>,        GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] testsuite enable PIE tests on FreeBSD
References: <555CBE89.5020500@fgznet.ch>
In-Reply-To: <555CBE89.5020500@fgznet.ch>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-05/txt/msg01879.txt.bz2

On 05/20/2015 11:04 AM, Andreas Tobler wrote:
> Hi,
>
> the attached patch enables some PIE tests on FreeBSD.
>
> Ok for trunk?
>
> Thanks,
> Andreas
>
> 2015-05-20  Andreas Tobler  <andreast@gcc.gnu.org>
>
>      * gcc.target/i386/pr32219-1.c: Enable test on FreeBSD.
>      * gcc.target/i386/pr32219-2.c: Likewise.
>      * gcc.target/i386/pr32219-3.c: Likewise.
>      * gcc.target/i386/pr32219-4.c: Likewise.
>      * gcc.target/i386/pr32219-5.c: Likewise.
>      * gcc.target/i386/pr32219-6.c: Likewise
>      * gcc.target/i386/pr32219-7.c: Likewise.
>      * gcc.target/i386/pr32219-8.c: Likewise.
>      * gcc.target/i386/pr39013-1.c: Likewise.
>      * gcc.target/i386/pr39013-2.c: Likewise.
>      * gcc.target/i386/pr64317.c: Likewise.
Wouldn't it be better to remove the target selector and instead add:

/* { dg-require-effective-target pie } */

In each of those tests?

While the net effect is the same today, it means there's only one place 
to change if another x86 target gains PIE support in the future.

Pre-approved using that style.
jeff