From: Aldy Hernandez <aldyh@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>,
Jan Hubicka <hubicka@ucw.cz>,
Jason Merrill <jason@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch 10/10] debug-early merge: compiler proper
Date: Wed, 20 May 2015 21:03:00 -0000 [thread overview]
Message-ID: <555CF12C.7080300@redhat.com> (raw)
In-Reply-To: <555CAD35.5040304@redhat.com>
> How does this version, which has been committed to the debug-early
> branch, look?
One more thing Richi. I merged trunk into the branch once again, and Go
broke. I tracked it down to a temporary that was being created late
that IMO shouldn't even get debug info.
The fact that it gets created with create_tmp_var_name() in the first
place is suspect. The problem is actually the type, which doesn't even
get passed through rest_of_type* or the debug_hooks->type_decl().
However, I see no reason to have these temporary variables even get fed
to the debugger, so I'm marking them as DECL_IGNORED_P.
If you want I can repost the whole compiler proper patch, but this is a
small enough change that y'all can just wave through.
I've committed the snippet below to the branch. Everything else is as
it was.
Branch retested on x86-64 Linux and has been merged with trunk.
commit 8824b5ecba26cef065e47b34609c72677c3c36fc
Author: Aldy Hernandez <aldyh@redhat.com>
Date: Wed May 20 16:31:14 2015 -0400
Set DECL_IGNORED_P on temporary arrays created in the switch
conversion pass.
diff --git a/gcc/tree-switch-conversion.c b/gcc/tree-switch-conversion.c
index 6b68a16..a4bcdba 100644
--- a/gcc/tree-switch-conversion.c
+++ b/gcc/tree-switch-conversion.c
@@ -1097,6 +1097,7 @@ build_one_array (gswitch *swtch, int num, tree
arr_index_type,
DECL_ARTIFICIAL (decl) = 1;
TREE_CONSTANT (decl) = 1;
TREE_READONLY (decl) = 1;
+ DECL_IGNORED_P (decl) = 1;
varpool_node::finalize_decl (decl);
fetch = build4 (ARRAY_REF, value_type, decl, tidx, NULL_TREE,
next prev parent reply other threads:[~2015-05-20 20:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 0:41 Aldy Hernandez
2015-05-18 11:06 ` Richard Biener
2015-05-18 14:47 ` Jan Hubicka
[not found] ` <555CAD35.5040304@redhat.com>
2015-05-20 21:03 ` Aldy Hernandez [this message]
2015-05-20 21:11 ` Jan Hubicka
2015-05-20 22:11 ` Aldy Hernandez
2015-05-22 9:00 ` Eric Botcazou
2015-05-22 11:45 ` Richard Biener
2015-05-22 13:41 ` Aldy Hernandez
2015-05-22 11:26 ` Richard Biener
2015-05-22 14:29 ` Aldy Hernandez
2015-05-27 13:18 ` Richard Biener
2015-05-27 12:50 ` Jason Merrill
2015-05-28 20:12 ` Aldy Hernandez
2015-05-28 20:54 ` Jason Merrill
2015-05-28 21:01 ` Jan Hubicka
2015-05-28 21:10 ` Jason Merrill
2015-05-28 21:16 ` Jan Hubicka
2015-05-29 12:07 ` Richard Biener
2015-05-29 19:33 ` Aldy Hernandez
2015-05-29 19:40 ` Richard Biener
2015-05-29 19:49 ` Jason Merrill
2015-05-31 7:53 ` Aldy Hernandez
2015-05-31 22:14 ` Jason Merrill
2015-06-01 8:03 ` Richard Biener
2015-06-01 8:04 ` Richard Biener
2015-06-01 15:43 ` Aldy Hernandez
2015-06-01 17:01 ` Richard Biener
2015-06-01 17:42 ` Aldy Hernandez
2015-06-02 8:13 ` Richard Biener
2015-06-02 19:25 ` Aldy Hernandez
2015-05-29 19:47 ` Jason Merrill
2015-05-28 21:31 ` Aldy Hernandez
2015-05-29 6:33 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555CF12C.7080300@redhat.com \
--to=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jason@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).