From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32776 invoked by alias); 20 May 2015 20:40:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32765 invoked by uid 89); 20 May 2015 20:40:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 May 2015 20:40:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4KKeEcW007476 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 20 May 2015 16:40:14 -0400 Received: from reynosa.quesejoda.com (vpn-59-26.rdu2.redhat.com [10.10.59.26]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4KKeCiP017430; Wed, 20 May 2015 16:40:13 -0400 Message-ID: <555CF12C.7080300@redhat.com> Date: Wed, 20 May 2015 21:03:00 -0000 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Richard Biener , Jan Hubicka , Jason Merrill CC: gcc-patches Subject: Re: [patch 10/10] debug-early merge: compiler proper References: <554C060F.6000609@redhat.com> <555CAD35.5040304@redhat.com> In-Reply-To: <555CAD35.5040304@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg01881.txt.bz2 > How does this version, which has been committed to the debug-early > branch, look? One more thing Richi. I merged trunk into the branch once again, and Go broke. I tracked it down to a temporary that was being created late that IMO shouldn't even get debug info. The fact that it gets created with create_tmp_var_name() in the first place is suspect. The problem is actually the type, which doesn't even get passed through rest_of_type* or the debug_hooks->type_decl(). However, I see no reason to have these temporary variables even get fed to the debugger, so I'm marking them as DECL_IGNORED_P. If you want I can repost the whole compiler proper patch, but this is a small enough change that y'all can just wave through. I've committed the snippet below to the branch. Everything else is as it was. Branch retested on x86-64 Linux and has been merged with trunk. commit 8824b5ecba26cef065e47b34609c72677c3c36fc Author: Aldy Hernandez Date: Wed May 20 16:31:14 2015 -0400 Set DECL_IGNORED_P on temporary arrays created in the switch conversion pass. diff --git a/gcc/tree-switch-conversion.c b/gcc/tree-switch-conversion.c index 6b68a16..a4bcdba 100644 --- a/gcc/tree-switch-conversion.c +++ b/gcc/tree-switch-conversion.c @@ -1097,6 +1097,7 @@ build_one_array (gswitch *swtch, int num, tree arr_index_type, DECL_ARTIFICIAL (decl) = 1; TREE_CONSTANT (decl) = 1; TREE_READONLY (decl) = 1; + DECL_IGNORED_P (decl) = 1; varpool_node::finalize_decl (decl); fetch = build4 (ARRAY_REF, value_type, decl, tidx, NULL_TREE,