Re: [PATCH 4/7] don't compare ARG_FRAME_POINTER_REGNUM and FRAME_POINTER_REGNUM with the preprocessor

[Jeff Law <law@redhat.com>]

On 05/20/2015 08:09 PM, tbsaunde+gcc@tbsaunde.org wrote:
> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>
> gcc/ChangeLog:
>
> 2015-05-20  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>
>
> 	* *.c: Remove comparison of ARG_FRAME_POINTER_REGNUM and
> 	FRAME_POINTER_REGNUM with the preprocessor.
This only hits a handful of files.  If you could go ahead and list them 
in the ChangeLog that'd probably be better than *.c :-)

> @@ -3781,16 +3778,14 @@ df_exit_block_uses_collect (struct df_collection_rec *collection_rec, bitmap exi
>       df_ref_record (DF_REF_ARTIFICIAL, collection_rec, regno_reg_rtx[i], NULL,
>   		   EXIT_BLOCK_PTR_FOR_FN (cfun), NULL, DF_REF_REG_USE, 0);
>
> -#if FRAME_POINTER_REGNUM != ARG_POINTER_REGNUM
>     /* It is deliberate that this is not put in the exit block uses but
>        I do not know why.  */
> -  if (reload_completed
> +  if (FRAME_POINTER_REGNUM != ARG_POINTER_REGNUM && reload_completed
Minor nit, go ahead and put the && reload_completed on the next line. 
While it fits in 80 columns, ISTM like it more naturally (in GNU style) 
belongs on its own line.  Interestingly enough this is the only instance 
where you formatted this way -- all the others have the FP/AP comparison 
on on its own line.

OK for the trunk.

jeff