From: Sandra Loosemore <sandra@codesourcery.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, testsuite] don't specify "dg-do run" explicitly for vect test cases
Date: Thu, 21 May 2015 16:08:00 -0000 [thread overview]
Message-ID: <555E016D.7080108@codesourcery.com> (raw)
In-Reply-To: <CAFiYyc3qU=9FR3Xs=o77b=F_qyk_7ZWe8xq8BOUYiRHczXjn8A@mail.gmail.com>
On 05/21/2015 03:08 AM, Richard Biener wrote:
> On Thu, May 21, 2015 at 7:12 AM, Sandra Loosemore
> <sandra@codesourcery.com> wrote:
>> On targets such as ARM, some arches are compatible with options needed to
>> enable compilation with vectorization, but the specific hardware (or
>> simulator or BSP) available for execution tests may not implement or enable
>> those features. The vect.exp test harness already includes some magic to
>> determine whether the target hw can execute vectorized code and sets
>> dg-do-what-default to compile the tests only if they can't be executed.
>> It's a mistake for individual tests to explicitly say "dg-do run" because
>> this overrides the harness's magic default and forces the test to be
>> executed, even if doing so just ends up wedging the target.
>>
>> I already committed two patches last fall (r215627 and r218427) to address
>> this, but people keep adding new vect test cases with the same problem, so
>> here is yet another installment to clean them up. I tested this on
>> arm-none-eabi with a fairly large collection of multilibs. OK to commit?
>
> Huh... I thought we have the check_vect () stuff for that...?
We do; this is what sets dg-do-what-default. But, if the test case
specifies dg-do whatever explicitly, that overrides the default. So,
don't do that! :-P
-Sandra
next prev parent reply other threads:[~2015-05-21 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 5:38 Sandra Loosemore
2015-05-21 9:10 ` Richard Biener
2015-05-21 16:08 ` Sandra Loosemore [this message]
2015-05-21 12:41 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E016D.7080108@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).