[patch, testsuite] don't specify "dg-do run" explicitly for vect test cases

[patch, testsuite] don't specify "dg-do run" explicitly for vect test cases

[Sandra Loosemore]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

On targets such as ARM, some arches are compatible with options needed 
to enable compilation with vectorization, but the specific hardware (or 
simulator or BSP) available for execution tests may not implement or 
enable those features.  The vect.exp test harness already includes some 
magic to determine whether the target hw can execute vectorized code and 
sets dg-do-what-default to compile the tests only if they can't be 
executed.  It's a mistake for individual tests to explicitly say "dg-do 
run" because this overrides the harness's magic default and forces the 
test to be executed, even if doing so just ends up wedging the target.

I already committed two patches last fall (r215627 and r218427) to 
address this, but people keep adding new vect test cases with the same 
problem, so here is yet another installment to clean them up.  I tested 
this on arm-none-eabi with a fairly large collection of multilibs.  OK 
to commit?

-Sandra


[-- Attachment #2: vect.log --]
[-- Type: text/x-log, Size: 433 bytes --]

2015-05-20  Sandra Loosemore  <sandra@codesourcery.com>

	gcc/testsuite/
	* gcc.dg/vect/bb-slp-pr65935.c: Remove explicit "dg-do run".
	* gcc.dg/vect/pr59354.c: Likewise.
	* gcc.dg/vect/pr64252.c: Likewise.
	* gcc.dg/vect/pr64404.c: Likewise.
	* gcc.dg/vect/pr64493.c: Likewise.
	* gcc.dg/vect/pr64495.c: Likewise.
	* gcc.dg/vect/pr64844.c: Likewise.
	* gcc.dg/vect/pr65518.c: Likewise.
	* gcc.dg/vect/vect-aggressive-1.c: Likewise.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: vect.patch --]
[-- Type: text/x-patch; name="vect.patch", Size: 3274 bytes --]

Index: gcc/testsuite/gcc.dg/vect/pr65518.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr65518.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/pr65518.c	(working copy)
@@ -1,5 +1,3 @@
-/* { dg-do run } */
-
 extern void abort (void);
 
 typedef struct giga
Index: gcc/testsuite/gcc.dg/vect/pr64493.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr64493.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/pr64493.c	(working copy)
@@ -1,5 +1,3 @@
-/* { dg-do run } */
-
 #include "tree-vect.h"
 
 int a, b, c, d, e, f, g, h;
Index: gcc/testsuite/gcc.dg/vect/pr64844.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr64844.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/pr64844.c	(working copy)
@@ -1,4 +1,3 @@
-/* { dg-do run } */
 /* { dg-require-effective-target vect_double } */
 /* { dg-additional-options "-ffast-math" } */
 
Index: gcc/testsuite/gcc.dg/vect/pr64495.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr64495.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/pr64495.c	(working copy)
@@ -1,5 +1,3 @@
-/* { dg-do run } */
-
 #include <assert.h>
 #include "tree-vect.h"
 
Index: gcc/testsuite/gcc.dg/vect/pr59354.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr59354.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/pr59354.c	(working copy)
@@ -1,4 +1,3 @@
-/* { dg-do run } */
 /* { dg-additional-options "-O3" } */
 
 #include "tree-vect.h"
Index: gcc/testsuite/gcc.dg/vect/pr64404.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr64404.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/pr64404.c	(working copy)
@@ -1,4 +1,3 @@
-/* { dg-do run } */
 /* { dg-additional-options "--param=sccvn-max-alias-queries-per-access=1" } */
 
 #include "tree-vect.h"
Index: gcc/testsuite/gcc.dg/vect/pr64252.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr64252.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/pr64252.c	(working copy)
@@ -1,6 +1,5 @@
 /* PR target/64252 */
 /* Test correctness of size 3 store groups permutation.  */
-/* { dg-do run } */
 /* { dg-additional-options "-O3" } */
 /* { dg-additional-options "-mavx" { target avx_runtime } } */
 
Index: gcc/testsuite/gcc.dg/vect/bb-slp-pr65935.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/bb-slp-pr65935.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/bb-slp-pr65935.c	(working copy)
@@ -1,4 +1,3 @@
-/* { dg-do run } */
 /* { dg-additional-options "-O3" } */
 /* { dg-require-effective-target vect_double } */
 
Index: gcc/testsuite/gcc.dg/vect/vect-aggressive-1.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/vect-aggressive-1.c	(revision 223468)
+++ gcc/testsuite/gcc.dg/vect/vect-aggressive-1.c	(working copy)
@@ -1,4 +1,3 @@
-/* { dg-do run } */
 /* { dg-require-effective-target vect_condition } */
 /* { dg-require-effective-target vect_simd_clones } */
 /* { dg-additional-options "-fopenmp-simd" } */

Re: [patch, testsuite] don't specify "dg-do run" explicitly for vect test cases

[Richard Biener]

On Thu, May 21, 2015 at 7:12 AM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
> On targets such as ARM, some arches are compatible with options needed to
> enable compilation with vectorization, but the specific hardware (or
> simulator or BSP) available for execution tests may not implement or enable
> those features.  The vect.exp test harness already includes some magic to
> determine whether the target hw can execute vectorized code and sets
> dg-do-what-default to compile the tests only if they can't be executed.
> It's a mistake for individual tests to explicitly say "dg-do run" because
> this overrides the harness's magic default and forces the test to be
> executed, even if doing so just ends up wedging the target.
>
> I already committed two patches last fall (r215627 and r218427) to address
> this, but people keep adding new vect test cases with the same problem, so
> here is yet another installment to clean them up.  I tested this on
> arm-none-eabi with a fairly large collection of multilibs.  OK to commit?

Huh... I thought we have the check_vect () stuff for that...?

> -Sandra
>

Re: [patch, testsuite] don't specify "dg-do run" explicitly for vect test cases

[Jeff Law]

On 05/20/2015 11:12 PM, Sandra Loosemore wrote:
> On targets such as ARM, some arches are compatible with options needed
> to enable compilation with vectorization, but the specific hardware (or
> simulator or BSP) available for execution tests may not implement or
> enable those features.  The vect.exp test harness already includes some
> magic to determine whether the target hw can execute vectorized code and
> sets dg-do-what-default to compile the tests only if they can't be
> executed.  It's a mistake for individual tests to explicitly say "dg-do
> run" because this overrides the harness's magic default and forces the
> test to be executed, even if doing so just ends up wedging the target.
>
> I already committed two patches last fall (r215627 and r218427) to
> address this, but people keep adding new vect test cases with the same
> problem, so here is yet another installment to clean them up.  I tested
> this on arm-none-eabi with a fairly large collection of multilibs.  OK
> to commit?
>
> -Sandra
>
>
> vect.log
>
>
> 2015-05-20  Sandra Loosemore<sandra@codesourcery.com>
>
> 	gcc/testsuite/
> 	* gcc.dg/vect/bb-slp-pr65935.c: Remove explicit "dg-do run".
> 	* gcc.dg/vect/pr59354.c: Likewise.
> 	* gcc.dg/vect/pr64252.c: Likewise.
> 	* gcc.dg/vect/pr64404.c: Likewise.
> 	* gcc.dg/vect/pr64493.c: Likewise.
> 	* gcc.dg/vect/pr64495.c: Likewise.
> 	* gcc.dg/vect/pr64844.c: Likewise.
> 	* gcc.dg/vect/pr65518.c: Likewise.
> 	* gcc.dg/vect/vect-aggressive-1.c: Likewise.
OK.
jeff

Re: [patch, testsuite] don't specify "dg-do run" explicitly for vect test cases

[Sandra Loosemore]

On 05/21/2015 03:08 AM, Richard Biener wrote:
> On Thu, May 21, 2015 at 7:12 AM, Sandra Loosemore
> <sandra@codesourcery.com> wrote:
>> On targets such as ARM, some arches are compatible with options needed to
>> enable compilation with vectorization, but the specific hardware (or
>> simulator or BSP) available for execution tests may not implement or enable
>> those features.  The vect.exp test harness already includes some magic to
>> determine whether the target hw can execute vectorized code and sets
>> dg-do-what-default to compile the tests only if they can't be executed.
>> It's a mistake for individual tests to explicitly say "dg-do run" because
>> this overrides the harness's magic default and forces the test to be
>> executed, even if doing so just ends up wedging the target.
>>
>> I already committed two patches last fall (r215627 and r218427) to address
>> this, but people keep adding new vect test cases with the same problem, so
>> here is yet another installment to clean them up.  I tested this on
>> arm-none-eabi with a fairly large collection of multilibs.  OK to commit?
>
> Huh... I thought we have the check_vect () stuff for that...?

We do; this is what sets dg-do-what-default.  But, if the test case 
specifies dg-do whatever explicitly, that overrides the default.  So, 
don't do that!  :-P

-Sandra