From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63162 invoked by alias); 21 May 2015 16:03:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63124 invoked by uid 89); 21 May 2015 16:03:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 May 2015 16:03:06 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1YvSw2-0003YY-P2 from Sandra_Loosemore@mentor.com ; Thu, 21 May 2015 09:03:02 -0700 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Thu, 21 May 2015 09:03:02 -0700 Message-ID: <555E016D.7080108@codesourcery.com> Date: Thu, 21 May 2015 16:08:00 -0000 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Richard Biener CC: GCC Patches Subject: Re: [patch, testsuite] don't specify "dg-do run" explicitly for vect test cases References: <555D6937.6090207@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg01996.txt.bz2 On 05/21/2015 03:08 AM, Richard Biener wrote: > On Thu, May 21, 2015 at 7:12 AM, Sandra Loosemore > wrote: >> On targets such as ARM, some arches are compatible with options needed to >> enable compilation with vectorization, but the specific hardware (or >> simulator or BSP) available for execution tests may not implement or enable >> those features. The vect.exp test harness already includes some magic to >> determine whether the target hw can execute vectorized code and sets >> dg-do-what-default to compile the tests only if they can't be executed. >> It's a mistake for individual tests to explicitly say "dg-do run" because >> this overrides the harness's magic default and forces the test to be >> executed, even if doing so just ends up wedging the target. >> >> I already committed two patches last fall (r215627 and r218427) to address >> this, but people keep adding new vect test cases with the same problem, so >> here is yet another installment to clean them up. I tested this on >> arm-none-eabi with a fairly large collection of multilibs. OK to commit? > > Huh... I thought we have the check_vect () stuff for that...? We do; this is what sets dg-do-what-default. But, if the test case specifies dg-do whatever explicitly, that overrides the default. So, don't do that! :-P -Sandra