From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
James Greenhalgh <James.Greenhalgh@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [PATCH][ARM/AArch64] Properly cost rev16 operand
Date: Thu, 21 May 2015 17:01:00 -0000 [thread overview]
Message-ID: <555E0EF3.9030807@arm.com> (raw)
In-Reply-To: <5551C2DA.1010804@arm.com>
Ping.
Thanks,
Kyrill
On 12/05/15 10:07, Kyrill Tkachov wrote:
> Ping.
> https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00013.html
>
> Thanks,
> Kyrill
> On 01/05/15 09:24, Kyrill Tkachov wrote:
>> Hi all,
>>
>> It occurs to me that in the IOR-of-shifts form of the rev16 operation we should be costing the operand properly.
>> For that we'd want to reuse the aarch_rev16_p function that does all the heavy lifting and get it to write the
>> innermost operand of the rev16 for further costing. In the process we relax that function a bit to accept any
>> rtx as the operand, not just REGs so that we can calculate the cost of moving them in a register appropriately.
>>
>> This patch does just that and updates the arm and aarch64 callsites appropriately so that the operands are
>> processed properly.
>>
>> In practice I don't expect this to make much difference since this patterns occurs rarely anyway, but it seems
>> like the 'right thing to do' (TM).
>>
>> Bootstrapped and tested on arm,aarch64.
>>
>> Ok for trunk?
>>
>> Thanks,
>> Kyrill
>>
>> 2015-05-01 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>
>> * config/arm/aarch-common-protos.h (aarch_rev16_p): Update signature
>> to take a second argument.
>> * config/arm/aarch-common.c (aarch_rev16_p): Add second argument.
>> Write inner-most rev16 argument to it if recognised.
>> (aarch_rev16_p_1): Likewise.
>> * config/arm/arm.c (arm_new_rtx_costs): Properly cost rev16 operand
>> in the IOR case.
>> * config/aarch64/aarch64.c (aarch64_rtx_costs): Likewise.
next prev parent reply other threads:[~2015-05-21 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 8:24 Kyrill Tkachov
2015-05-12 9:07 ` Kyrill Tkachov
2015-05-21 17:01 ` Kyrill Tkachov [this message]
2015-05-26 9:05 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E0EF3.9030807@arm.com \
--to=kyrylo.tkachov@arm.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).