From: Andreas Tobler <andreast-list@fgznet.ch>
To: Jeff Law <law@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] testsuite enable PIE tests on FreeBSD
Date: Thu, 21 May 2015 18:23:00 -0000 [thread overview]
Message-ID: <555E2078.9000503@fgznet.ch> (raw)
In-Reply-To: <555CEEEE.50902@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]
On 20.05.15 22:30, Jeff Law wrote:
> On 05/20/2015 11:04 AM, Andreas Tobler wrote:
>> Hi,
>>
>> the attached patch enables some PIE tests on FreeBSD.
>>
>> Ok for trunk?
>>
>> Thanks,
>> Andreas
>>
>> 2015-05-20 Andreas Tobler <andreast@gcc.gnu.org>
>>
>> * gcc.target/i386/pr32219-1.c: Enable test on FreeBSD.
>> * gcc.target/i386/pr32219-2.c: Likewise.
>> * gcc.target/i386/pr32219-3.c: Likewise.
>> * gcc.target/i386/pr32219-4.c: Likewise.
>> * gcc.target/i386/pr32219-5.c: Likewise.
>> * gcc.target/i386/pr32219-6.c: Likewise
>> * gcc.target/i386/pr32219-7.c: Likewise.
>> * gcc.target/i386/pr32219-8.c: Likewise.
>> * gcc.target/i386/pr39013-1.c: Likewise.
>> * gcc.target/i386/pr39013-2.c: Likewise.
>> * gcc.target/i386/pr64317.c: Likewise.
> Wouldn't it be better to remove the target selector and instead add:
>
> /* { dg-require-effective-target pie } */
>
> In each of those tests?
>
> While the net effect is the same today, it means there's only one place
> to change if another x86 target gains PIE support in the future.
>
> Pre-approved using that style.
Thanks!
Tested on amd64-freebsd and CentOS.
Andreas
This is what I committed:
2015-05-21 Andreas Tobler <andreast@gcc.gnu.org>
* gcc.target/i386/pr32219-1.c: Use 'dg-require-effective-target pie'
instead of listing several targets on its own.
* gcc.target/i386/pr32219-2.c: Likewise.
* gcc.target/i386/pr32219-3.c: Likewise.
* gcc.target/i386/pr32219-4.c: Likewise.
* gcc.target/i386/pr32219-5.c: Likewise.
* gcc.target/i386/pr32219-6.c: Likewise
* gcc.target/i386/pr32219-7.c: Likewise.
* gcc.target/i386/pr32219-8.c: Likewise.
* gcc.target/i386/pr39013-1.c: Likewise.
* gcc.target/i386/pr39013-2.c: Likewise.
* gcc.target/i386/pr64317.c: Likewise.
[-- Attachment #2: fbsd_pie3_test.diff --]
[-- Type: text/plain, Size: 4194 bytes --]
Index: pr32219-1.c
===================================================================
--- pr32219-1.c (revision 223448)
+++ pr32219-1.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile { target *-*-linux* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpie" } */
/* Initialized common symbol with -fpie. */
Index: pr32219-2.c
===================================================================
--- pr32219-2.c (revision 223448)
+++ pr32219-2.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile { target *-*-linux* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpic" } */
/* Common symbol with -fpic. */
Index: pr32219-3.c
===================================================================
--- pr32219-3.c (revision 223448)
+++ pr32219-3.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile { target *-*-linux* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpie" } */
/* Weak common symbol with -fpie. */
Index: pr32219-4.c
===================================================================
--- pr32219-4.c (revision 223448)
+++ pr32219-4.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile { target *-*-linux* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpic" } */
/* Weak common symbol with -fpic. */
Index: pr32219-5.c
===================================================================
--- pr32219-5.c (revision 223448)
+++ pr32219-5.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile { target *-*-linux* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpie" } */
/* Initialized symbol with -fpie. */
Index: pr32219-6.c
===================================================================
--- pr32219-6.c (revision 223448)
+++ pr32219-6.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile { target *-*-linux* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpic" } */
/* Initialized symbol with -fpic. */
Index: pr32219-7.c
===================================================================
--- pr32219-7.c (revision 223448)
+++ pr32219-7.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile { target *-*-linux* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpie" } */
/* Weak initialized symbol with -fpie. */
Index: pr32219-8.c
===================================================================
--- pr32219-8.c (revision 223448)
+++ pr32219-8.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile { target *-*-linux* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpic" } */
/* Weak initialized symbol with -fpic. */
Index: pr39013-1.c
===================================================================
--- pr39013-1.c (revision 223448)
+++ pr39013-1.c (working copy)
@@ -1,5 +1,6 @@
/* PR target/39013 */
-/* { dg-do compile { target *-*-linux* *-*-gnu* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpie -std=gnu89" } */
inline int foo (void);
Index: pr39013-2.c
===================================================================
--- pr39013-2.c (revision 223448)
+++ pr39013-2.c (working copy)
@@ -1,5 +1,6 @@
/* PR target/39013 */
-/* { dg-do compile { target *-*-linux* *-*-gnu* } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target pie } */
/* { dg-options "-O2 -fpie -std=gnu99" } */
inline int foo (void); /* { dg-warning "declared but never defined" } */
Index: pr64317.c
===================================================================
--- pr64317.c (revision 223448)
+++ pr64317.c (working copy)
@@ -1,4 +1,4 @@
-/* { dg-do compile { target { *-*-linux* && ia32 } } } */
+/* { dg-do compile { target { { *-*-freebsd* *-*-linux* } && ia32 } } } */
/* { dg-options "-O2 -fpie" } */
/* { dg-final { scan-assembler "addl\[ \\t\]+\[$\]_GLOBAL_OFFSET_TABLE_, %ebx" } } */
/* { dg-final { scan-assembler "movl\[ \\t\]+c@GOTOFF\[(\]%ebx\[)\]" } } */
next prev parent reply other threads:[~2015-05-21 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 17:11 Andreas Tobler
2015-05-20 20:40 ` Jeff Law
2015-05-21 18:23 ` Andreas Tobler [this message]
2015-05-21 20:44 ` Andreas Tobler
2015-05-22 22:54 ` Jeff Law
2015-05-25 10:29 ` Andreas Tobler
2015-05-28 11:49 ` Thomas Schwinge
2015-05-25 14:00 Dominique Dhumieres
2015-05-25 20:14 ` Andreas Tobler
2015-05-26 14:18 ` Jeff Law
2015-05-26 14:14 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E2078.9000503@fgznet.ch \
--to=andreast-list@fgznet.ch \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).