From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42944 invoked by alias); 21 May 2015 18:14:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42935 invoked by uid 89); 21 May 2015 18:14:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_50,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: smtp.fgznet.ch Received: from mail.fgznet.ch (HELO smtp.fgznet.ch) (81.92.96.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 21 May 2015 18:14:24 +0000 Received: from [192.168.225.14] (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id t4LIEGiM088081; Thu, 21 May 2015 20:14:20 +0200 (CEST) (envelope-from andreast-list@fgznet.ch) Message-ID: <555E2078.9000503@fgznet.ch> Date: Thu, 21 May 2015 18:23:00 -0000 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jeff Law , GCC Patches Subject: Re: [patch] testsuite enable PIE tests on FreeBSD References: <555CBE89.5020500@fgznet.ch> <555CEEEE.50902@redhat.com> In-Reply-To: <555CEEEE.50902@redhat.com> Content-Type: multipart/mixed; boundary="------------070003050005000005030303" X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02019.txt.bz2 This is a multi-part message in MIME format. --------------070003050005000005030303 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1814 On 20.05.15 22:30, Jeff Law wrote: > On 05/20/2015 11:04 AM, Andreas Tobler wrote: >> Hi, >> >> the attached patch enables some PIE tests on FreeBSD. >> >> Ok for trunk? >> >> Thanks, >> Andreas >> >> 2015-05-20 Andreas Tobler >> >> * gcc.target/i386/pr32219-1.c: Enable test on FreeBSD. >> * gcc.target/i386/pr32219-2.c: Likewise. >> * gcc.target/i386/pr32219-3.c: Likewise. >> * gcc.target/i386/pr32219-4.c: Likewise. >> * gcc.target/i386/pr32219-5.c: Likewise. >> * gcc.target/i386/pr32219-6.c: Likewise >> * gcc.target/i386/pr32219-7.c: Likewise. >> * gcc.target/i386/pr32219-8.c: Likewise. >> * gcc.target/i386/pr39013-1.c: Likewise. >> * gcc.target/i386/pr39013-2.c: Likewise. >> * gcc.target/i386/pr64317.c: Likewise. > Wouldn't it be better to remove the target selector and instead add: > > /* { dg-require-effective-target pie } */ > > In each of those tests? > > While the net effect is the same today, it means there's only one place > to change if another x86 target gains PIE support in the future. > > Pre-approved using that style. Thanks! Tested on amd64-freebsd and CentOS. Andreas This is what I committed: 2015-05-21 Andreas Tobler * gcc.target/i386/pr32219-1.c: Use 'dg-require-effective-target pie' instead of listing several targets on its own. * gcc.target/i386/pr32219-2.c: Likewise. * gcc.target/i386/pr32219-3.c: Likewise. * gcc.target/i386/pr32219-4.c: Likewise. * gcc.target/i386/pr32219-5.c: Likewise. * gcc.target/i386/pr32219-6.c: Likewise * gcc.target/i386/pr32219-7.c: Likewise. * gcc.target/i386/pr32219-8.c: Likewise. * gcc.target/i386/pr39013-1.c: Likewise. * gcc.target/i386/pr39013-2.c: Likewise. * gcc.target/i386/pr64317.c: Likewise. --------------070003050005000005030303 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="fbsd_pie3_test.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fbsd_pie3_test.diff" Content-length: 5686 SW5kZXg6IHByMzIyMTktMS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHByMzIyMTktMS5jCShyZXZpc2lvbiAyMjM0NDgpCisrKyBwcjMyMjE5LTEu Ywkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDUgQEAKLS8qIHsgZGctZG8g Y29tcGlsZSB7IHRhcmdldCAqLSotbGludXgqIH0gfSAqLworLyogeyBkZy1k byBjb21waWxlIH0gKi8KKy8qIHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFy Z2V0IHBpZSB9ICovCiAvKiB7IGRnLW9wdGlvbnMgIi1PMiAtZnBpZSIgfSAq LwogCiAvKiBJbml0aWFsaXplZCBjb21tb24gc3ltYm9sIHdpdGggLWZwaWUu ICAqLwpJbmRleDogcHIzMjIxOS0yLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gcHIzMjIxOS0yLmMJKHJldmlzaW9uIDIyMzQ0OCkKKysrIHByMzIy MTktMi5jCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNSBAQAotLyogeyBk Zy1kbyBjb21waWxlIHsgdGFyZ2V0ICotKi1saW51eCogfSB9ICovCisvKiB7 IGRnLWRvIGNvbXBpbGUgfSAqLworLyogeyBkZy1yZXF1aXJlLWVmZmVjdGl2 ZS10YXJnZXQgcGllIH0gKi8KIC8qIHsgZGctb3B0aW9ucyAiLU8yIC1mcGlj IiB9ICovCiAKIC8qIENvbW1vbiBzeW1ib2wgd2l0aCAtZnBpYy4gICovCklu ZGV4OiBwcjMyMjE5LTMuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBw cjMyMjE5LTMuYwkocmV2aXNpb24gMjIzNDQ4KQorKysgcHIzMjIxOS0zLmMJ KHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw1IEBACi0vKiB7IGRnLWRvIGNv bXBpbGUgeyB0YXJnZXQgKi0qLWxpbnV4KiB9IH0gKi8KKy8qIHsgZGctZG8g Y29tcGlsZSB9ICovCisvKiB7IGRnLXJlcXVpcmUtZWZmZWN0aXZlLXRhcmdl dCBwaWUgfSAqLwogLyogeyBkZy1vcHRpb25zICItTzIgLWZwaWUiIH0gKi8K IAogLyogV2VhayBjb21tb24gc3ltYm9sIHdpdGggLWZwaWUuICAqLwpJbmRl eDogcHIzMjIxOS00LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcHIz MjIxOS00LmMJKHJldmlzaW9uIDIyMzQ0OCkKKysrIHByMzIyMTktNC5jCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNSBAQAotLyogeyBkZy1kbyBjb21w aWxlIHsgdGFyZ2V0ICotKi1saW51eCogfSB9ICovCisvKiB7IGRnLWRvIGNv bXBpbGUgfSAqLworLyogeyBkZy1yZXF1aXJlLWVmZmVjdGl2ZS10YXJnZXQg cGllIH0gKi8KIC8qIHsgZGctb3B0aW9ucyAiLU8yIC1mcGljIiB9ICovCiAK IC8qIFdlYWsgY29tbW9uIHN5bWJvbCB3aXRoIC1mcGljLiAgKi8KSW5kZXg6 IHByMzIyMTktNS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHByMzIy MTktNS5jCShyZXZpc2lvbiAyMjM0NDgpCisrKyBwcjMyMjE5LTUuYwkod29y a2luZyBjb3B5KQpAQCAtMSw0ICsxLDUgQEAKLS8qIHsgZGctZG8gY29tcGls ZSB7IHRhcmdldCAqLSotbGludXgqIH0gfSAqLworLyogeyBkZy1kbyBjb21w aWxlIH0gKi8KKy8qIHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IHBp ZSB9ICovCiAvKiB7IGRnLW9wdGlvbnMgIi1PMiAtZnBpZSIgfSAqLwogCiAv KiBJbml0aWFsaXplZCBzeW1ib2wgd2l0aCAtZnBpZS4gICovCkluZGV4OiBw cjMyMjE5LTYuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwcjMyMjE5 LTYuYwkocmV2aXNpb24gMjIzNDQ4KQorKysgcHIzMjIxOS02LmMJKHdvcmtp bmcgY29weSkKQEAgLTEsNCArMSw1IEBACi0vKiB7IGRnLWRvIGNvbXBpbGUg eyB0YXJnZXQgKi0qLWxpbnV4KiB9IH0gKi8KKy8qIHsgZGctZG8gY29tcGls ZSB9ICovCisvKiB7IGRnLXJlcXVpcmUtZWZmZWN0aXZlLXRhcmdldCBwaWUg fSAqLwogLyogeyBkZy1vcHRpb25zICItTzIgLWZwaWMiIH0gKi8KIAogLyog SW5pdGlhbGl6ZWQgc3ltYm9sIHdpdGggLWZwaWMuICAqLwpJbmRleDogcHIz MjIxOS03LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcHIzMjIxOS03 LmMJKHJldmlzaW9uIDIyMzQ0OCkKKysrIHByMzIyMTktNy5jCSh3b3JraW5n IGNvcHkpCkBAIC0xLDQgKzEsNSBAQAotLyogeyBkZy1kbyBjb21waWxlIHsg dGFyZ2V0ICotKi1saW51eCogfSB9ICovCisvKiB7IGRnLWRvIGNvbXBpbGUg fSAqLworLyogeyBkZy1yZXF1aXJlLWVmZmVjdGl2ZS10YXJnZXQgcGllIH0g Ki8KIC8qIHsgZGctb3B0aW9ucyAiLU8yIC1mcGllIiB9ICovCiAKIC8qIFdl YWsgaW5pdGlhbGl6ZWQgc3ltYm9sIHdpdGggLWZwaWUuICAqLwpJbmRleDog cHIzMjIxOS04LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcHIzMjIx OS04LmMJKHJldmlzaW9uIDIyMzQ0OCkKKysrIHByMzIyMTktOC5jCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDQgKzEsNSBAQAotLyogeyBkZy1kbyBjb21waWxl IHsgdGFyZ2V0ICotKi1saW51eCogfSB9ICovCisvKiB7IGRnLWRvIGNvbXBp bGUgfSAqLworLyogeyBkZy1yZXF1aXJlLWVmZmVjdGl2ZS10YXJnZXQgcGll IH0gKi8KIC8qIHsgZGctb3B0aW9ucyAiLU8yIC1mcGljIiB9ICovCiAKIC8q IFdlYWsgaW5pdGlhbGl6ZWQgc3ltYm9sIHdpdGggLWZwaWMuICAqLwpJbmRl eDogcHIzOTAxMy0xLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcHIz OTAxMy0xLmMJKHJldmlzaW9uIDIyMzQ0OCkKKysrIHByMzkwMTMtMS5jCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNiBAQAogLyogUFIgdGFyZ2V0LzM5 MDEzICovCi0vKiB7IGRnLWRvIGNvbXBpbGUgeyB0YXJnZXQgKi0qLWxpbnV4 KiAqLSotZ251KiB9IH0gKi8KKy8qIHsgZGctZG8gY29tcGlsZSB9ICovCisv KiB7IGRnLXJlcXVpcmUtZWZmZWN0aXZlLXRhcmdldCBwaWUgfSAqLwogLyog eyBkZy1vcHRpb25zICItTzIgLWZwaWUgLXN0ZD1nbnU4OSIgfSAqLwogCiBp bmxpbmUgaW50IGZvbyAodm9pZCk7CkluZGV4OiBwcjM5MDEzLTIuYwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBwcjM5MDEzLTIuYwkocmV2aXNpb24g MjIzNDQ4KQorKysgcHIzOTAxMy0yLmMJKHdvcmtpbmcgY29weSkKQEAgLTEs NSArMSw2IEBACiAvKiBQUiB0YXJnZXQvMzkwMTMgKi8KLS8qIHsgZGctZG8g Y29tcGlsZSB7IHRhcmdldCAqLSotbGludXgqICotKi1nbnUqIH0gfSAqLwor LyogeyBkZy1kbyBjb21waWxlIH0gKi8KKy8qIHsgZGctcmVxdWlyZS1lZmZl Y3RpdmUtdGFyZ2V0IHBpZSB9ICovCiAvKiB7IGRnLW9wdGlvbnMgIi1PMiAt ZnBpZSAtc3RkPWdudTk5IiB9ICovCiAKIGlubGluZSBpbnQgZm9vICh2b2lk KTsJCS8qIHsgZGctd2FybmluZyAiZGVjbGFyZWQgYnV0IG5ldmVyIGRlZmlu ZWQiIH0gKi8KSW5kZXg6IHByNjQzMTcuYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBwcjY0MzE3LmMJKHJldmlzaW9uIDIyMzQ0OCkKKysrIHByNjQz MTcuYwkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLS8qIHsgZGct ZG8gY29tcGlsZSB7IHRhcmdldCB7ICotKi1saW51eCogJiYgaWEzMiB9IH0g fSAqLworLyogeyBkZy1kbyBjb21waWxlIHsgdGFyZ2V0IHsgeyAqLSotZnJl ZWJzZCogKi0qLWxpbnV4KiB9ICYmIGlhMzIgfSB9IH0gKi8KIC8qIHsgZGct b3B0aW9ucyAiLU8yIC1mcGllIiB9ICovCiAvKiB7IGRnLWZpbmFsIHsgc2Nh bi1hc3NlbWJsZXIgImFkZGxcWyBcXHRcXStcWyRcXV9HTE9CQUxfT0ZGU0VU X1RBQkxFXywgJWVieCIgfSB9ICovCiAvKiB7IGRnLWZpbmFsIHsgc2Nhbi1h c3NlbWJsZXIgIm1vdmxcWyBcXHRcXStjQEdPVE9GRlxbKFxdJWVieFxbKVxd IiB9IH0gKi8K --------------070003050005000005030303--