From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109064 invoked by alias); 22 May 2015 19:59:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108294 invoked by uid 89); 22 May 2015 19:59:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 22 May 2015 19:59:12 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53210) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1Yvt66-0005ZC-Hk for gcc-patches@gnu.org; Fri, 22 May 2015 15:59:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yvt65-0004Mn-5m for gcc-patches@gnu.org; Fri, 22 May 2015 15:59:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvt65-0004MV-0B for gcc-patches@gnu.org; Fri, 22 May 2015 15:59:09 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id ADEADBACC4; Fri, 22 May 2015 19:59:06 +0000 (UTC) Received: from localhost.localdomain ([10.3.113.14]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4MJx54T022381; Fri, 22 May 2015 15:59:05 -0400 Message-ID: <555F8A88.2010701@redhat.com> Date: Fri, 22 May 2015 20:38:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Mikhail Maltsev , gcc-patches Subject: Re: [PATCH][RFA] PR rtl-optimization/66237 References: <555EE873.9010202@gmail.com> In-Reply-To: <555EE873.9010202@gmail.com> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02165.txt.bz2 On 05/22/2015 02:27 AM, Mikhail Maltsev wrote: > This patch fixes a bug introduced by refactoring. A cast from rtx_insn > to rtx_jump_insn in fix_crossing_conditional_branches was placed before > the check, and that caused ICE if the instruction is actually a call, > rather than a jump. > > Bootstrapped/regtested on x86_64 linux and tested the regressed case > (PR34999) on aarch64 crosscompiler using the provided profiling data. > > OK for trunk? > > -- Regards, Mikhail Maltsev > > > pr66237.clog > > > gcc/ChangeLog: > > 2015-05-22 Mikhail Maltsev > > PR rtl-optimization/66237 > * bb-reorder.c (fix_crossing_conditional_branches): Fix wrong > location of an "as_a" cast. OK. jeff