From: Nathan Sidwell <nathan@acm.org>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Jason Merrill <jason@redhat.com>
Subject: [C++ Patch] Fix 66243, silent cast of scoped enum
Date: Mon, 25 May 2015 01:26:00 -0000 [thread overview]
Message-ID: <55625CB6.1020403@acm.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
This is a pretty obvious patch. We were permitting a scoped enum initializer of
an another enum to silently decay to int. That's not right, only unscoped enums
have that privilege.
committed.
nathan
[-- Attachment #2: 66243.patch --]
[-- Type: text/x-patch, Size: 1139 bytes --]
2015-05-24 Nathan Sidwell <nathan@acm.org>
cp/
PR c++/66243
* decl.c (build_enumerator): Don't silently convert scoped enums.
testsuite/
PR c++/66243
* g++.dg/cpp0x/pr66243.C: New.
Index: cp/decl.c
===================================================================
--- cp/decl.c (revision 223613)
+++ cp/decl.c (working copy)
@@ -13097,7 +13097,8 @@ build_enumerator (tree name, tree value,
if (tmp_value)
value = tmp_value;
}
- else if (! INTEGRAL_OR_ENUMERATION_TYPE_P (TREE_TYPE (value)))
+ else if (! INTEGRAL_OR_UNSCOPED_ENUMERATION_TYPE_P
+ (TREE_TYPE (value)))
value = perform_implicit_conversion_flags
(ENUM_UNDERLYING_TYPE (enumtype), value, tf_warning_or_error,
LOOKUP_IMPLICIT | LOOKUP_NO_NARROWING);
Index: testsuite/g++.dg/cpp0x/pr66243.C
===================================================================
--- testsuite/g++.dg/cpp0x/pr66243.C (revision 0)
+++ testsuite/g++.dg/cpp0x/pr66243.C (working copy)
@@ -0,0 +1,12 @@
+// { dg-do compile { target c++11 } }
+
+enum class A
+{
+ X
+};
+
+enum class B
+{
+ X = A::X // { dg-error "could not convert" }
+};
+
next reply other threads:[~2015-05-24 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 1:26 Nathan Sidwell [this message]
2015-05-25 19:52 ` Jason Merrill
2015-05-25 20:29 ` Nathan Sidwell
2015-05-26 7:49 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55625CB6.1020403@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).