From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17236 invoked by alias); 25 May 2015 19:35:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17223 invoked by uid 89); 25 May 2015 19:35:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: smtp.fgznet.ch Received: from mail.fgznet.ch (HELO smtp.fgznet.ch) (81.92.96.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 25 May 2015 19:34:57 +0000 Received: from [192.168.225.14] (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id t4PJYeJQ078469; Mon, 25 May 2015 21:34:52 +0200 (CEST) (envelope-from andreast-list@fgznet.ch) Message-ID: <55637950.3010805@fgznet.ch> Date: Mon, 25 May 2015 19:44:00 -0000 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: John Marino , gcc-patches Subject: Re: [PATCH] Contribute FreeBSD unwind support (x86_64 and x86) References: <555CE558.5070404@marino.st> <555CECB3.3020909@fgznet.ch> In-Reply-To: <555CECB3.3020909@fgznet.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02259.txt.bz2 On 20.05.15 22:21, Andreas Tobler wrote: > On 20.05.15 21:49, John Marino wrote: >> I have maintained unwind support for FreeBSD i386 and x86_64 in my >> "gnat-aux" repository for many years (I created it). I've always >> intended on contributing it back to GCC, but I never got around to >> "proving" it worked until now. >> >> The version I've been using actually has two flavors: FreeBSD 8 and >> below and FreeBSD 9 and above. However, the last of the FreeBSD 8 >> releases reaches EOL at the end of June so the unwind support I've >> attached here drops the FreeBSD 8 variation for simplicity's sake. >> >> I was under the impression that MD unwinding was used for more than just >> GNAT but it looks like that impression was wrong. When I ran the >> testsuite, the only tests affected were Ada tests. > > It is, libjava uses it. > > >> Note that I provided a similar unwind support for DragonFly a few months >> ago. Please consider applying the attached patch to gcc trunk. (copy >> of patch found here: >> http://leaf.dragonflybsd.org/~marino/freebsd/freebsd-unwind-support.diff ) >> >> Suggested text for libgcc/ChangeLog: >> >> 2015-05-XX John Marino >> >> * config.host (i[34567]86-*-freebsd*, x86_64-*-freebsd*): >> Set md_unwind_header >> * config/i386/freebsd-unwind.h: New. >> >> >> Also please recall that my copyright assignment to FSF is in order! > > Testing patch locally now. So, finally my findings. With some additional work on libjava for FreeBSD (pending patch on my side), I can confirm that this patch is a working prerequisite for proper signal handling in libjava. E.g, the magic Throw_2 test case succeeds. I have not found any regressions on the FreeBSD side. And I really would like to see this patch go into trunk. My tests were done on amd64 and i386 FreeBSD -CURRENT. Thanks a lot! Andreas