public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Dominique Dhumieres <dominiq@lps.ens.fr>, andreast-list@fgznet.ch
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [patch] testsuite enable PIE tests on FreeBSD
Date: Tue, 26 May 2015 14:14:00 -0000	[thread overview]
Message-ID: <55647EDF.8060705@redhat.com> (raw)
In-Reply-To: <20150525124240.A11DC105@mailhost.lps.ens.fr>

On 05/25/2015 06:42 AM, Dominique Dhumieres wrote:
>> Wouldn't it be better to remove the target selector and instead add:
>>
>> /* { dg-require-effective-target pie } */
>> ...
>
> This allows the tests to be run on Darwin and fail because the code generated does not
> match the scan-assembler:
>
> FAIL: gcc.target/i386/iinline-attr-2.c scan-assembler p2align
> FAIL: gcc.target/i386/pr32219-1.c scan-assembler movl[ \\t]xxx\\\\(%rip\\\\), %eax
> FAIL: gcc.target/i386/pr32219-3.c scan-assembler movl[ \\t]xxx\\\\(%rip\\\\), %eax
> FAIL: gcc.target/i386/pr32219-3.c scan-assembler-not xxx@GOTPCREL
> FAIL: gcc.target/i386/pr32219-5.c scan-assembler movl[ \\t]xxx\\\\(%rip\\\\), %eax
> FAIL: gcc.target/i386/pr32219-6.c scan-assembler xxx@GOTPCREL
> FAIL: gcc.target/i386/pr32219-7.c scan-assembler movl[ \\t]xxx\\\\(%rip\\\\), %eax
> FAIL: gcc.target/i386/pr32219-7.c scan-assembler-not xxx@GOTPCREL
> FAIL: gcc.target/i386/pr39013-1.c scan-assembler bar@PLT
> FAIL: gcc.target/i386/pr39013-1.c scan-assembler foo@PLT
> FAIL: gcc.target/i386/pr39013-2.c scan-assembler bar@PLT
> FAIL: gcc.target/i386/pr39013-2.c scan-assembler foo@PLT
>
> I suspect that this will also be the case for gcc.target/i386/pr64317.c.
Can you dig a little bit deeper -- is it the case that we just need a 
more general pattern to match whatever assembler is necessary for Darwin?

Or is it the case that Darwin doesn't have some particular capability in 
its assembler/linker that these tests depend on (and thus we need 
another check-effective-target-whatever)

I'm happy to iterate with Andreas to get this addressed for Darwin, but 
neither Andreas nor myself really know much about that platform.

jeff

  parent reply	other threads:[~2015-05-26 14:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 14:00 Dominique Dhumieres
2015-05-25 20:14 ` Andreas Tobler
2015-05-26 14:18   ` Jeff Law
2015-05-26 14:14 ` Jeff Law [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-05-20 17:11 Andreas Tobler
2015-05-20 20:40 ` Jeff Law
2015-05-21 18:23   ` Andreas Tobler
2015-05-21 20:44     ` Andreas Tobler
2015-05-22 22:54       ` Jeff Law
2015-05-25 10:29         ` Andreas Tobler
2015-05-28 11:49   ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55647EDF.8060705@redhat.com \
    --to=law@redhat.com \
    --cc=andreast-list@fgznet.ch \
    --cc=dominiq@lps.ens.fr \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).