public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Ilya Enkovich <enkovich.gnu@gmail.com>
Cc: Sandra Loosemore <sandra@codesourcery.com>,
	       Joseph Myers <joseph@codesourcery.com>,
	       Richard Biener <rguenther@suse.de>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX
Date: Wed, 27 May 2015 15:35:00 -0000	[thread overview]
Message-ID: <5565E07E.2070703@redhat.com> (raw)
In-Reply-To: <20150526091327.GI47912@msticlxl57.ims.intel.com>

On 05/26/2015 03:13 AM, Ilya Enkovich wrote:
> On 06 Apr 09:28, Jeff Law wrote:
>> On 04/06/2015 09:17 AM, Ilya Enkovich wrote:
>>>>
>>>> To tell the truth, I can't figure out what this means from a user
>>>> perspective.  How does a user know whether the linker option is
>>>> being ignored, or if they have a new enough linker?  If the linker
>>>> available at configuration time doesn't support the option, does
>>>> that mean the option will never be passed and users will never know
>>>> that there are gaping holes in the pointer bounds checking?
>>>>
>>>> My suggestion would be to pass the option unconditionally and make
>>>> the documentation say something like
>>>
>>> This option was rejected.
>> Right.  There really isn't a good option here because we don't have
>> the infrastructure to query the linker's capabilities at link time.
>>
>> Though I do wonder if we could issue a warning in the case where the
>> configure test indicated -z bndplt was not supported.
>>
>> It'd obviously mean a link warning every time an end user tried to
>> use that toolchain to create a DSO or executable with MPX
>> protection.  But that may be better than silently leaving some code
>> unprotected.
>>
>>
>> Jeff
>>
>
> Hi,
>
> Here is a patch to add a note in case we build dynamic MPX codes and don't pass '-z bndplt'.  Does it look OK?
>
> Thanks,
> Ilya
> --
> gcc/
>
> 2015-05-26  Ilya Enkovich  <enkovich.gnu@gmail.com>
>
> 	* config/i386/linux-common.h (MPX_SPEC): Add link
> 	warning.
>
> libmpx/
>
> 2015-05-26  Ilya Enkovich  <enkovich.gnu@gmail.com>
>
> 	* configure.ac: Add link_mpx_warning.
> 	* libmpx.spec.in: Likewise.
> 	* configure: Regenerate.
Is there a way to do this outside of the specs mechanism?  If done in 
the specs, are these warnings translated for locales?

Jeff

  reply	other threads:[~2015-05-27 15:19 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 11:56 Ilya Enkovich
2015-03-18 12:03 ` H.J. Lu
2015-03-18 12:05   ` Ilya Enkovich
2015-03-18 12:08     ` H.J. Lu
2015-03-18 12:13       ` Ilya Enkovich
2015-03-18 12:25         ` H.J. Lu
2015-03-18 12:42           ` Richard Biener
2015-03-18 13:24             ` Ilya Enkovich
2015-03-18 13:32               ` H.J. Lu
2015-03-18 13:41                 ` Ilya Enkovich
2015-03-18 13:52                   ` H.J. Lu
2015-03-18 13:59                     ` Ilya Enkovich
2015-03-18 14:02                       ` Jakub Jelinek
2015-03-18 14:31                         ` H.J. Lu
2015-03-18 14:42                           ` H.J. Lu
2015-03-18 16:14                             ` Ilya Enkovich
2015-03-18 16:45                               ` H.J. Lu
2015-03-18 17:13                                 ` Ilya Enkovich
2015-03-18 17:14                                   ` H.J. Lu
2015-03-18 17:34                                     ` Ilya Enkovich
2015-03-18 17:39                                       ` H.J. Lu
2015-03-18 18:13                                         ` Ilya Enkovich
2015-03-18 14:03                       ` Robert Dewar
2015-03-18 14:33                         ` Markus Trippelsdorf
2015-03-23 10:19 ` Ilya Enkovich
2015-03-31  9:47   ` Ilya Enkovich
2015-04-02  4:34     ` Jeff Law
2015-04-02 11:01       ` H.J. Lu
2015-04-03 19:34     ` Joseph Myers
2015-04-06  1:45       ` Sandra Loosemore
2015-04-06  2:35         ` H.J. Lu
2015-04-06  3:08           ` Sandra Loosemore
2015-04-06 15:18         ` Ilya Enkovich
2015-04-06 15:28           ` Jeff Law
2015-04-06 15:54             ` Ilya Enkovich
2015-05-26  9:26             ` Ilya Enkovich
2015-05-27 15:35               ` Jeff Law [this message]
2015-06-03  9:04                 ` Ilya Enkovich
2015-06-03 15:29                   ` Joseph Myers
2015-06-03 15:59                     ` Ilya Enkovich
2015-06-03 16:03                       ` Joseph Myers
2015-06-04 14:14                         ` Ilya Enkovich
2015-06-04 15:55                           ` Joseph Myers
2015-06-05 14:44                             ` Ilya Enkovich
2015-06-25 19:00                               ` Jeff Law
2015-04-06 17:15           ` Sandra Loosemore
2015-04-07 19:01             ` Jeff Law
2015-04-07 19:29               ` H.J. Lu
2015-04-07 20:12                 ` Markus Trippelsdorf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5565E07E.2070703@redhat.com \
    --to=law@redhat.com \
    --cc=enkovich.gnu@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=rguenther@suse.de \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).