From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19032 invoked by alias); 28 May 2015 10:22:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19019 invoked by uid 89); 28 May 2015 10:22:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 May 2015 10:22:22 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-20.uk.mimecast.lan; Thu, 28 May 2015 11:22:17 +0100 Received: from [10.2.207.65] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 28 May 2015 11:22:07 +0100 Message-ID: <5566EC4C.6060204@arm.com> Date: Thu, 28 May 2015 10:50:00 -0000 From: Alan Lawrence User-Agent: Thunderbird 2.0.0.24 (X11/20101213) MIME-Version: 1.0 To: Christophe Lyon CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH 13/14][ARM/AArch64 testsuite] Use gcc-dg-runtest in advsimd-intrinsics.exp References: <5537D241.1000606@arm.com> <5537DC12.1050201@arm.com> <55649E74.6020600@arm.com> In-Reply-To: X-MC-Unique: UDkdYyLORFScq5tK3ZrFcA-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02608.txt.bz2 Christophe Lyon wrote: > On 26 May 2015 at 18:25, Alan Lawrence wrote: >> I don't see this symptom - I am able to execute such subsets with either= my, >> or Sandra's, advsimd-intrinsics.exp. >=20 > I didn't try to run with your patch, I thought it was an oversight of you= rs. >=20 > Sorry, indeed I've just checked that gcc-dg-runtest includes the filter. >=20 >> Is it that you have to check runtest_file_p because you are setting >> gcc_parallel_test_enable to 0? >> >> I'm doing more testing now, but I think I can drop my advsimd-intrinsics= .exp >> changes altogether; I'll post an updated patch series shortly. >> >> In the meantime I'm curious as to why you found the gcc_parallel_test_en= able >> necessary? (And is it safe to reset it to 1 afterwards, rather than to a >> saved value?) > See https://gcc.gnu.org/ml/gcc/2014-10/msg00081.html So after working through the differences between Sandra's and my patch, I f= ind=20 the existing advsimd-intrinsics.exp achieves pretty much the same thing, an= d=20 preserves the same list of test variants (e.g. the -Og -g from=20 set-torture-options which I had removed). However, I've tried testing advsimd-intrinsics.exp (both the whole thing, a= nd=20 individual tests using RUNTESTFLAGS) with and without this hunk: @@ -57,20 +57,7 @@ set-torture-options $C_TORTURE_OPTIONS {{}} $LTO_TORTURE= _OPTI set additional_flags [add_options_for_arm_neon ""] # Main loop. -foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c]] { - # If we're only testing specific files and this isn't one of them, ski= p it. - if ![runtest_file_p $runtests $src] then { - continue - } - - # runtest_file_p is already run above, and the code below can run - # runtest_file_p again, make sure everything for this test is - # performed if the above runtest_file_p decided this runtest - # instance should execute the test - gcc_parallel_test_enable 0 - gcc-dg-runtest $src "" $additional_flags - gcc_parallel_test_enable 1 -} +gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] ""=20 ${additional_flags} and find exactly the same tests are run and pass. My hypothesis is thus tha= t you=20 only need the explicit loop, manual checking of runtest_file_p, and=20 gcc_parallel_test_enable, in order to do *both* c-torture-execute *and*=20 gcc-dg-runtest; since we are now only doing the latter, this is unnecessary= .=20 Does that make sense? (If you agree, I'll propose that as a standalone clea= nup=20 patch.) Cheers, Alan