public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mikael Morin <mikael.morin@sfr.fr>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Andre Vehreschild <vehre@gmx.de>,
	Paul Richard Thomas	<paul.richard.thomas@gmail.com>,
	"fortran@gcc.gnu.org"	<fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR66079 - [6 Regression] memory leak with source allocation in internal subprogram
Date: Thu, 28 May 2015 15:22:00 -0000	[thread overview]
Message-ID: <55672D24.9040500@sfr.fr> (raw)
In-Reply-To: <20150527210948.GA15571@troutmask.apl.washington.edu>

Le 27/05/2015 23:09, Steve Kargl a écrit :
> On Wed, May 27, 2015 at 06:24:25PM +0200, Mikael Morin wrote:
>> Le 27/05/2015 16:07, Andre Vehreschild a ?crit :
>>> Hi Paul, hi Mikael,
>>>
>>> about renaming the identifier emitted: I would like to keep it short. Remember,
>>> there is always a number attached to it, which makes it unique. Furthermore
>>> does "alloc_source_tmp" sound unnecessarily long to me. It tastes like we do
>>> not trust the unique identifier mechanism established in gfortran. But that is
>>> just my personal taste.
>>>
>> Then let's go with "source", which seems to get the majority of the
>> votes.  It remains an improvement over "expr3" and "atmp".
>>
> 
> You do realize that expr3 holds things other than the 
> expression in a source= in an allocate, right? 
> 
I know there is mold.  I'm not aware of anything else.
Now that you tell about it, I realize that the code in that area doesn't
seem to  check for mold vs source.

Mikael

  reply	other threads:[~2015-05-28 14:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-23 17:53 Paul Richard Thomas
2015-05-23 21:30 ` Andre Vehreschild
2015-05-23 21:35   ` Paul Richard Thomas
2015-05-24 18:55     ` Andre Vehreschild
2015-05-24 11:25   ` Paul Richard Thomas
2015-05-25 10:25     ` Paul Richard Thomas
2015-05-25 11:52       ` Andre Vehreschild
2015-05-25 18:09         ` Mikael Morin
2015-05-27  8:38         ` Paul Richard Thomas
2015-05-27 14:16           ` Andre Vehreschild
2015-05-27 16:42             ` Mikael Morin
2015-05-27 21:28               ` Steve Kargl
2015-05-28 15:22                 ` Mikael Morin [this message]
2015-05-28 15:24                   ` Andre Vehreschild
2015-05-25 18:08       ` Mikael Morin
2015-05-25 18:41         ` Steve Kargl
2015-06-11 16:00         ` Paul Richard Thomas
2015-10-18 20:04     ` Paul Richard Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55672D24.9040500@sfr.fr \
    --to=mikael.morin@sfr.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul.richard.thomas@gmail.com \
    --cc=sgk@troutmask.apl.washington.edu \
    --cc=vehre@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).