public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>,
	       Richard Biener <richard.guenther@gmail.com>,
	       Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch 10/10] debug-early merge: compiler proper
Date: Fri, 29 May 2015 19:47:00 -0000	[thread overview]
Message-ID: <5568BED9.4090909@redhat.com> (raw)
In-Reply-To: <5568B32A.1010100@redhat.com>

On 05/29/2015 02:42 PM, Aldy Hernandez wrote:
> unsigned int i=555;
>
> int main()
> {
>    unsigned int array[i];
>    ...
> }
>
> For the VLA, I'd like to check if we have an array type with a missing
> DW_AT_{upper,lower}_bound late in the game, and fill it in.
>
> During early dwarf we only have an uninitialized gimple register
> representing the bound

Ah, I see, from gimplify_type_sizes.

> and loc_list_from_tree() cannot find the RTL
> with the final bound location.  Thus, we end up with a missing bound,
> which I propose to fill in late dwarf.

OK, that makes sense.  I wonder if we should emit debug info for the 
gimple register; that would allow us to fill in the bound during early 
dwarf.

> Obviously I was doing some nonsense with TYPE_SIZE != INTEGER_CST, when
> in reality I should probably check that TREE_CODE (type) == ARRAY_TYPE
> and that we are missing the bound late (by looking for DW_AT_*_bound in
> the cached DIE).

But this sounds reasonable.

Jason


  parent reply	other threads:[~2015-05-29 19:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  0:41 Aldy Hernandez
2015-05-18 11:06 ` Richard Biener
2015-05-18 14:47   ` Jan Hubicka
     [not found]   ` <555CAD35.5040304@redhat.com>
2015-05-20 21:03     ` Aldy Hernandez
2015-05-20 21:11       ` Jan Hubicka
2015-05-20 22:11         ` Aldy Hernandez
2015-05-22  9:00           ` Eric Botcazou
2015-05-22 11:45           ` Richard Biener
2015-05-22 13:41             ` Aldy Hernandez
2015-05-22 11:26     ` Richard Biener
2015-05-22 14:29       ` Aldy Hernandez
2015-05-27 13:18         ` Richard Biener
2015-05-27 12:50     ` Jason Merrill
2015-05-28 20:12       ` Aldy Hernandez
2015-05-28 20:54         ` Jason Merrill
2015-05-28 21:01           ` Jan Hubicka
2015-05-28 21:10             ` Jason Merrill
2015-05-28 21:16               ` Jan Hubicka
2015-05-29 12:07           ` Richard Biener
2015-05-29 19:33           ` Aldy Hernandez
2015-05-29 19:40             ` Richard Biener
2015-05-29 19:49               ` Jason Merrill
2015-05-31  7:53                 ` Aldy Hernandez
2015-05-31 22:14                   ` Jason Merrill
2015-06-01  8:03                     ` Richard Biener
2015-06-01  8:04                       ` Richard Biener
2015-06-01 15:43                         ` Aldy Hernandez
2015-06-01 17:01                           ` Richard Biener
2015-06-01 17:42                             ` Aldy Hernandez
2015-06-02  8:13                               ` Richard Biener
2015-06-02 19:25                                 ` Aldy Hernandez
2015-05-29 19:47             ` Jason Merrill [this message]
2015-05-28 21:31       ` Aldy Hernandez
2015-05-29  6:33         ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5568BED9.4090909@redhat.com \
    --to=jason@redhat.com \
    --cc=aldyh@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).