public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Yaakov Selkowitz <yselkowi@redhat.com>,
	gcc-patches@gcc.gnu.org,
	       "binutils@sourceware.org" <binutils@sourceware.org>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] toplevel: fixes for in-tree libiconv
Date: Sat, 30 May 2015 05:42:00 -0000	[thread overview]
Message-ID: <5569418E.30807@redhat.com> (raw)
In-Reply-To: <1432934043.7892.30.camel@redhat.com>

On 05/29/2015 03:14 PM, Yaakov Selkowitz wrote:
> This is the first in a series of patches to make a build with an in-tree
> GNU libiconv work as designed.
>
> This patch fixes dependencies for parallel make, and avoids failures
> with make targets not supported by GNU libiconv.
>
> -- Yaakov Selkowitz Associate Software Engineer, ARM Red Hat, Inc.
>
>
> 0001-toplevel-libiconv.patch
>
>
> 2015-05-29  Yaakov Selkowitz<yselkowi@redhat.com>
>
> 	* Makefile.def (libiconv): Mark pdf/html/info as missing.
> 	(configure-gcc): Depend on all-libiconv.
> 	(all-gcc): Ditto.
> 	(configure-libcpp): Ditto.
> 	(all-libcpp): Ditto.
> 	(configure-intl): Ditto.
> 	* Makefile.in: Regenerate.
How was this patch tested?  I don't see anything glaringly wrong, but 
stranger things have happened.

I think just a bootstrap check is fine here (rather than a bootstrap + 
regression test).  If you could bootstrap with and without an in-tree 
libiconv it'd be appreciated.

Jeff

  reply	other threads:[~2015-05-30  4:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 21:42 Yaakov Selkowitz
2015-05-30  5:42 ` Jeff Law [this message]
2015-06-16  5:02 ` DJ Delorie
2015-06-19  2:37   ` Yaakov Selkowitz
2015-06-19  7:47     ` DJ Delorie
2015-07-01 20:43 ` Yaakov Selkowitz
2015-08-07  5:15   ` DJ Delorie
2015-07-01 20:45 ` Yaakov Selkowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5569418E.30807@redhat.com \
    --to=law@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yselkowi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).