From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63780 invoked by alias); 30 May 2015 04:50:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63752 invoked by uid 89); 30 May 2015 04:50:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 30 May 2015 04:50:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5FDAB36356C; Sat, 30 May 2015 04:50:23 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-36.phx2.redhat.com [10.3.113.36]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4U4oMPe021787; Sat, 30 May 2015 00:50:22 -0400 Message-ID: <5569418E.30807@redhat.com> Date: Sat, 30 May 2015 05:42:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yaakov Selkowitz , gcc-patches@gcc.gnu.org, "binutils@sourceware.org" , "gdb-patches@sourceware.org" Subject: Re: [PATCH] toplevel: fixes for in-tree libiconv References: <1432934043.7892.30.camel@redhat.com> In-Reply-To: <1432934043.7892.30.camel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02843.txt.bz2 On 05/29/2015 03:14 PM, Yaakov Selkowitz wrote: > This is the first in a series of patches to make a build with an in-tree > GNU libiconv work as designed. > > This patch fixes dependencies for parallel make, and avoids failures > with make targets not supported by GNU libiconv. > > -- Yaakov Selkowitz Associate Software Engineer, ARM Red Hat, Inc. > > > 0001-toplevel-libiconv.patch > > > 2015-05-29 Yaakov Selkowitz > > * Makefile.def (libiconv): Mark pdf/html/info as missing. > (configure-gcc): Depend on all-libiconv. > (all-gcc): Ditto. > (configure-libcpp): Ditto. > (all-libcpp): Ditto. > (configure-intl): Ditto. > * Makefile.in: Regenerate. How was this patch tested? I don't see anything glaringly wrong, but stranger things have happened. I think just a bootstrap check is fine here (rather than a bootstrap + regression test). If you could bootstrap with and without an in-tree libiconv it'd be appreciated. Jeff