From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53990 invoked by alias); 1 Jun 2015 09:50:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53980 invoked by uid 89); 1 Jun 2015 09:50:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Jun 2015 09:50:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C891F28; Mon, 1 Jun 2015 02:50:34 -0700 (PDT) Received: from collaborate-mta1.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTP id 293303F458; Mon, 1 Jun 2015 02:50:32 -0700 (PDT) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 9A1BF13F775; Mon, 1 Jun 2015 04:50:31 -0500 (CDT) Message-ID: <556C2AE7.2070003@arm.com> Date: Mon, 01 Jun 2015 09:50:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Alex Velenko , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] [PATCH][ARM] Fix thumb-ltu.c testcase. References: <1433152137-12570-1-git-send-email-alex.velenko@arm.com> In-Reply-To: <1433152137-12570-1-git-send-email-alex.velenko@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00023.txt.bz2 On 01/06/15 10:48, Alex Velenko wrote: > Hi, > > This patch fix thumb-ltu.c to pass excess error test. > Without default -std=gnu90 flag, this testcase started failing > as some functions were called before being predefined. > > Is patch ok? > > gcc/testsuite > > 2015-06-01 Alex Velenko > > * gcc.target/arm/thumb-ltu.c (foo): Predefined. > (bar): Predefined. > --- > gcc/testsuite/gcc.target/arm/thumb-ltu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gcc/testsuite/gcc.target/arm/thumb-ltu.c b/gcc/testsuite/gcc.target/arm/thumb-ltu.c > index d057ea3..124b025 100644 > --- a/gcc/testsuite/gcc.target/arm/thumb-ltu.c > +++ b/gcc/testsuite/gcc.target/arm/thumb-ltu.c > @@ -2,6 +2,9 @@ > /* { dg-require-effective-target arm_thumb1_ok } */ > /* { dg-options "-mcpu=arm1136jf-s -mthumb -O2" } */ > > +int foo(); > +int bar(); > + Surely this is, extern int foo (void); extern int bar (void); > void f(unsigned a, unsigned b, unsigned c, unsigned d) > { > if (a <= b || c > d) > OK with that change. Ramana