From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96962 invoked by alias); 1 Jun 2015 11:38:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 96953 invoked by uid 89); 1 Jun 2015 11:38:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 01 Jun 2015 11:38:55 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 151CEABA5; Mon, 1 Jun 2015 11:38:51 +0000 (UTC) Message-ID: <556C444B.4040907@suse.cz> Date: Mon, 01 Jun 2015 11:38:00 -0000 From: =?UTF-8?B?TWFydGluIExpxaFrYQ==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Vidya Praveen CC: GCC Patches Subject: Re: [PATCH, RFC] New memory usage statistics infrastructure References: <555604F0.40802@suse.cz> <55688F1E.4070704@arm.com> In-Reply-To: <55688F1E.4070704@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00049.txt.bz2 On 05/29/2015 06:09 PM, Vidya Praveen wrote: > > Martin, > > The following change: > > @@ -2655,10 +2655,10 @@ s-iov: build/gcov-iov$(build_exeext) $(BASEVER) $(DEVPHASE) > > GCOV_OBJS = gcov.o > gcov$(exeext): $(GCOV_OBJS) $(LIBDEPS) > - +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) $(LIBS) -o $@ > + +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) build/hash-table.o ggc-none.o $(LIBS) -o $@ > > > seem to cause canadian cross build failure for arm and aarch64 on x86_64 as > build/hash-table.o and ggc-none.o are not built by the same compiler? > > arm-none-linux-gnueabi-g++ -no-pie -g -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing > +-Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wn > build/hash-table.o ggc-none.o libcommon.a ../libcpp/libcpp.a ../libbacktrace/.libs/libbacktrace.a ../libiberty/libiberty.a .. > +/libdecnumber/libdecnumber.a -o gcov > build/hash-table.o: file not recognized: File format not recognized > collect2: error: ld returned 1 exit status > make[1]: *** [gcov] Error 1 > > > Should it be: > > - +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) $(LIBS) -o $@ > + +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) hash-table.o ggc-none.o $(LIBS) -o $@ > > instead? Hello Vidya. Thanks for pointing out. To be honest, I'm not a build system guru and it's hard for me to verify that the change you suggest is the correct. May I please ask you for sending a patch to mailing? Thanks, Martin > > VP. > > > On 15/05/15 15:38, Martin Liška wrote: >> Hello. >> >> Following patch attempts to rewrite memory reports for GCC's internal allocations >> so that it uses a new template type. The type shares parts which are currently duplicated, >> adds support for special 'counters' and introduces new support for hash-{set,map,table}. >> >> Transformation of the current code is a bit tricky as we internally used hash-table as main >> data structure which takes care of location-related allocations. As I want to add support even >> for hash tables (and all derived types), header files inclusion and forward declaration is utilized. >> >> Feel free to comment the patch, as well as missing features one may want to track by location sensitive >> memory allocation. >> >> Attachment contains sample output taken from tramp3d-v4.cpp. >> >> Thanks, >> Martin >> >