public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Cesar Philippidis <cesar@codesourcery.com>
To: Bernd Schmidt <bernds@codesourcery.com>,
	GCC Patches	<gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: Re: [gomp4] Worker-single predication
Date: Tue, 02 Jun 2015 18:03:00 -0000	[thread overview]
Message-ID: <556DEE77.90307@codesourcery.com> (raw)
In-Reply-To: <556C813B.5020907@codesourcery.com>

On 06/01/2015 08:58 AM, Bernd Schmidt wrote:
> This extends the previous vector-single support to also handle
> worker-level predication. We can't use the shfl insn because workers
> will live across multiple warps, so we use a location in memory to
> broadcast the branch target.
> This also fixes the oversight where basic blocks inside a parallel
> region but outside all loops weren't being predicated.
> 
> A special case is added for worker-single vector-partitioned; we add a
> jump over the entire loop that is taken by the inactive workers and add
> no predication inside this loop.
> 
> Committed on gomp-4_0-branch.

Thanks. This fixed the problems that I was seeing with variables outside
of acc loops.

I see that calls are being predicated at the moment. Those will need
special handling once we tackle acc routines.

Cesar

      parent reply	other threads:[~2015-06-02 17:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 15:59 Bernd Schmidt
2015-06-02 10:29 ` Thomas Schwinge
2015-06-02 11:07 ` Thomas Schwinge
2015-06-03 11:20   ` Bernd Schmidt
2015-06-02 18:03 ` Cesar Philippidis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556DEE77.90307@codesourcery.com \
    --to=cesar@codesourcery.com \
    --cc=bernds@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).