public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: John Marino <gnugcc@marino.st>
To: Arnaud Charlet <charlet@adacore.com>,
	 Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org, Thomas Quinot <quinot@adacore.com>
Subject: Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD
Date: Wed, 03 Jun 2015 08:25:00 -0000	[thread overview]
Message-ID: <556EB67B.5010704@marino.st> (raw)
In-Reply-To: <20150603073036.GA10341@adacore.com>

On 6/3/2015 09:30, Arnaud Charlet wrote:
>>> Note 1)  All TOOL_TARGET_PAIRS in gcc/ada/gcc-interface/Makefile.in
>>> should be removed for most (if not all) platforms as they were moved to
>>> gnattools/configure and are now no-ops.  However, for this patch set I
>>> only removed them for FreeBSD.
>>
>> They are actually used if you configure with --disable-libada so should be
>> preserved.
> 
> Right.

Okay, so that means the Makefile.in patch needs changing in two ways:
1.  Don't remove TOOL_TARGET_PAIRS lines from two FreeBSD targets
2.  Add TOOL_TARGET_PAIRS line to new DragonFly target.

Is a new submission necessary or can this be handled by committer?
A new submission will take me a few days because I'm traveling ATM.



>>
>> This looks good to me modulo the TOOL_TARGET_PAIRS thing.  But ChangeLog
>> lines
>> must all start with a capital letter and end with a period.
>>
>> Please leave a couple of more days for Thomas or Arno to comment though.
> 
> My main question is: who will maintain these files after they are in
> (e.g. regularly test this configuration and post patches to fix any breakage)?

Well, both FreeBSD and DragonFly are officially supported platforms.
They both utilize FreeBSD ports which supports the last 5 releases and
the development release of GCC.  Additionally it features 2-3 versions
that specifically build GNAT.  So it is built continuously and breakage
will be found.

In all likelihood, I would be the first to discover the breakage and
also the most likely to submit the patch.  This covers all three targets
(both FreeBSD and the one DragonFly).

By the way, I am not aware of "official" build testing on the two
existing FreeBSD configurations, so in any case there is no regression.

Jonathan Wakely told me about gcc build farms -- I'd like to get a
continuous, automated DragonFly test build going as well.

John

  reply	other threads:[~2015-06-03  8:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 23:36 John Marino
2015-06-03  7:30 ` Eric Botcazou
2015-06-03  7:33   ` Arnaud Charlet
2015-06-03  8:25     ` John Marino [this message]
2015-06-03  9:14       ` Arnaud Charlet
2015-06-04 18:24         ` John Marino
2015-06-04 21:04           ` Arnaud Charlet
     [not found]             ` <5570AE5B.9090804@marino.st>
2015-06-08  7:31               ` Eric Botcazou
2015-06-05 13:08           ` Arnaud Charlet
2015-06-03  9:41   ` Thomas Quinot
2015-06-03 10:46     ` John Marino
2015-06-03 11:17       ` Thomas Quinot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556EB67B.5010704@marino.st \
    --to=gnugcc@marino.st \
    --cc=charlet@adacore.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=quinot@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).