public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
To: Shiva Chen <shiva0217@gmail.com>,
	 GCC Patches <gcc-patches@gcc.gnu.org>,
	"nickc@redhat.com" <nickc@redhat.com>,
	 Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code
Date: Wed, 03 Jun 2015 08:31:00 -0000	[thread overview]
Message-ID: <556EBA0E.2080507@arm.com> (raw)
In-Reply-To: <CAH=PD7ZegqZCA8gMy+7X1gBqx6w9HS5fnGSxkzVp61Uwn8c8Jg@mail.gmail.com>



On 03/06/15 05:12, Shiva Chen wrote:
<snip>

>
> It seems that stl should generate as stlne.
>
> Otherwise, slt will get null reference when r3 is 0.
>
>
> To fix the issue, add %? when output stl assembly pattern in sync.md.



Please also mark these patterns as predicable.

i.e. (set_attr "predicable" "yes").

>
> Is this patch ok for trunk?

Ouch, ok with that change for trunk and affected release branches after 
a round of regression testing.

Can I also confirm you have a copyright assignment on file ?

regards
Ramana

>
> Thanks,
> Shiva
>

  reply	other threads:[~2015-06-03  8:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03  5:27 Shiva Chen
2015-06-03  8:31 ` Ramana Radhakrishnan [this message]
2015-06-03  8:36 ` Kyrill Tkachov
     [not found]   ` <556EBBAC.2020504@arm.com>
2015-06-03  8:53     ` Kyrill Tkachov
2015-06-03  9:33       ` Shiva Chen
2015-06-04  4:51         ` Shiva Chen
2015-06-04  8:24           ` Kyrill Tkachov
2015-06-04  8:42             ` Richard Earnshaw
2015-06-04 10:01               ` Shiva Chen
2015-06-04 10:04                 ` Kyrill Tkachov
2015-06-05  8:34                   ` Shiva Chen
2015-06-05  8:35                     ` Kyrill Tkachov
2015-06-05 10:59                       ` Shiva Chen
2015-06-05 13:11                         ` Kyrill Tkachov
2015-06-05 13:14                           ` Richard Earnshaw
2015-06-05 14:02                             ` Kyrill Tkachov
2015-06-09  8:44                               ` Kyrill Tkachov
2015-09-30 17:10                                 ` Kyrill Tkachov
2015-10-01  9:10                                   ` Kyrill Tkachov
2015-10-01 20:21                                     ` Christophe Lyon
2015-10-02 12:57                                       ` Kyrill Tkachov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556EBA0E.2080507@arm.com \
    --to=ramana.radhakrishnan@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nickc@redhat.com \
    --cc=shiva0217@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).