From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54145 invoked by alias); 3 Jun 2015 08:25:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54101 invoked by uid 89); 3 Jun 2015 08:25:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jun 2015 08:25:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC5072AA; Wed, 3 Jun 2015 01:25:55 -0700 (PDT) Received: from collaborate-mta1.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTP id 883E03F447; Wed, 3 Jun 2015 01:25:51 -0700 (PDT) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id BB78D13F730; Wed, 3 Jun 2015 03:25:50 -0500 (CDT) Message-ID: <556EBA0E.2080507@arm.com> Date: Wed, 03 Jun 2015 08:31:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Shiva Chen , GCC Patches , "nickc@redhat.com" , Richard Earnshaw Subject: Re: [GCC, ARM] armv8 linux toolchain asan testcase fail due to stl missing conditional code References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00280.txt.bz2 On 03/06/15 05:12, Shiva Chen wrote: > > It seems that stl should generate as stlne. > > Otherwise, slt will get null reference when r3 is 0. > > > To fix the issue, add %? when output stl assembly pattern in sync.md. Please also mark these patterns as predicable. i.e. (set_attr "predicable" "yes"). > > Is this patch ok for trunk? Ouch, ok with that change for trunk and affected release branches after a round of regression testing. Can I also confirm you have a copyright assignment on file ? regards Ramana > > Thanks, > Shiva >