public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alex Velenko <Alex.Velenko@arm.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
	 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Re: [PATCH] [PATCH][ARM] Fix thumb-ltu.c testcase.
Date: Thu, 04 Jun 2015 12:55:00 -0000	[thread overview]
Message-ID: <55704A70.9030406@arm.com> (raw)
In-Reply-To: <556C2AE7.2070003@arm.com>

On 01/06/15 10:50, Ramana Radhakrishnan wrote:
>
>
> On 01/06/15 10:48, Alex Velenko wrote:
>> Hi,
>>
>> This patch fix thumb-ltu.c to pass excess error test.
>> Without default -std=gnu90 flag, this testcase started failing
>> as some functions were called before being predefined.
>>
>> Is patch ok?
>>
>> gcc/testsuite
>>
>> 2015-06-01  Alex Velenko  <Alex.Velenko@arm.com>
>>
>>          * gcc.target/arm/thumb-ltu.c (foo): Predefined.
>>          (bar): Predefined.
>> ---
>>   gcc/testsuite/gcc.target/arm/thumb-ltu.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/gcc/testsuite/gcc.target/arm/thumb-ltu.c
>> b/gcc/testsuite/gcc.target/arm/thumb-ltu.c
>> index d057ea3..124b025 100644
>> --- a/gcc/testsuite/gcc.target/arm/thumb-ltu.c
>> +++ b/gcc/testsuite/gcc.target/arm/thumb-ltu.c
>> @@ -2,6 +2,9 @@
>>   /* { dg-require-effective-target arm_thumb1_ok } */
>>   /* { dg-options "-mcpu=arm1136jf-s -mthumb -O2" } */
>>
>> +int foo();
>> +int bar();
>> +
>
> Surely this is,
>
>
> extern int foo (void);
> extern int bar (void);
>
>>   void f(unsigned a, unsigned b, unsigned c, unsigned d)
>>   {
>>     if (a <= b || c > d)
>>
>
>
> OK with that change.
>
> Ramana
>
Committed with said change r223982.
Is patch ok for fsf-5 backport?
Alex

  reply	other threads:[~2015-06-04 12:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01  9:49 Alex Velenko
2015-06-01  9:50 ` Ramana Radhakrishnan
2015-06-04 12:55   ` Alex Velenko [this message]
2015-06-04 13:08     ` Ramana Radhakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55704A70.9030406@arm.com \
    --to=alex.velenko@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ramana.radhakrishnan@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).