* [PATCH] [PATCH][ARM] Fix thumb-ltu.c testcase.
@ 2015-06-01 9:49 Alex Velenko
2015-06-01 9:50 ` Ramana Radhakrishnan
0 siblings, 1 reply; 4+ messages in thread
From: Alex Velenko @ 2015-06-01 9:49 UTC (permalink / raw)
To: gcc-patches; +Cc: Ramana.Radhakrishnan
Hi,
This patch fix thumb-ltu.c to pass excess error test.
Without default -std=gnu90 flag, this testcase started failing
as some functions were called before being predefined.
Is patch ok?
gcc/testsuite
2015-06-01 Alex Velenko <Alex.Velenko@arm.com>
* gcc.target/arm/thumb-ltu.c (foo): Predefined.
(bar): Predefined.
---
gcc/testsuite/gcc.target/arm/thumb-ltu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/testsuite/gcc.target/arm/thumb-ltu.c b/gcc/testsuite/gcc.target/arm/thumb-ltu.c
index d057ea3..124b025 100644
--- a/gcc/testsuite/gcc.target/arm/thumb-ltu.c
+++ b/gcc/testsuite/gcc.target/arm/thumb-ltu.c
@@ -2,6 +2,9 @@
/* { dg-require-effective-target arm_thumb1_ok } */
/* { dg-options "-mcpu=arm1136jf-s -mthumb -O2" } */
+int foo();
+int bar();
+
void f(unsigned a, unsigned b, unsigned c, unsigned d)
{
if (a <= b || c > d)
--
1.8.1.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [PATCH][ARM] Fix thumb-ltu.c testcase.
2015-06-01 9:49 [PATCH] [PATCH][ARM] Fix thumb-ltu.c testcase Alex Velenko
@ 2015-06-01 9:50 ` Ramana Radhakrishnan
2015-06-04 12:55 ` Alex Velenko
0 siblings, 1 reply; 4+ messages in thread
From: Ramana Radhakrishnan @ 2015-06-01 9:50 UTC (permalink / raw)
To: Alex Velenko, gcc-patches
On 01/06/15 10:48, Alex Velenko wrote:
> Hi,
>
> This patch fix thumb-ltu.c to pass excess error test.
> Without default -std=gnu90 flag, this testcase started failing
> as some functions were called before being predefined.
>
> Is patch ok?
>
> gcc/testsuite
>
> 2015-06-01 Alex Velenko <Alex.Velenko@arm.com>
>
> * gcc.target/arm/thumb-ltu.c (foo): Predefined.
> (bar): Predefined.
> ---
> gcc/testsuite/gcc.target/arm/thumb-ltu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/arm/thumb-ltu.c b/gcc/testsuite/gcc.target/arm/thumb-ltu.c
> index d057ea3..124b025 100644
> --- a/gcc/testsuite/gcc.target/arm/thumb-ltu.c
> +++ b/gcc/testsuite/gcc.target/arm/thumb-ltu.c
> @@ -2,6 +2,9 @@
> /* { dg-require-effective-target arm_thumb1_ok } */
> /* { dg-options "-mcpu=arm1136jf-s -mthumb -O2" } */
>
> +int foo();
> +int bar();
> +
Surely this is,
extern int foo (void);
extern int bar (void);
> void f(unsigned a, unsigned b, unsigned c, unsigned d)
> {
> if (a <= b || c > d)
>
OK with that change.
Ramana
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH] [PATCH][ARM] Fix thumb-ltu.c testcase.
2015-06-01 9:50 ` Ramana Radhakrishnan
@ 2015-06-04 12:55 ` Alex Velenko
2015-06-04 13:08 ` Ramana Radhakrishnan
0 siblings, 1 reply; 4+ messages in thread
From: Alex Velenko @ 2015-06-04 12:55 UTC (permalink / raw)
To: Ramana Radhakrishnan, gcc-patches
On 01/06/15 10:50, Ramana Radhakrishnan wrote:
>
>
> On 01/06/15 10:48, Alex Velenko wrote:
>> Hi,
>>
>> This patch fix thumb-ltu.c to pass excess error test.
>> Without default -std=gnu90 flag, this testcase started failing
>> as some functions were called before being predefined.
>>
>> Is patch ok?
>>
>> gcc/testsuite
>>
>> 2015-06-01 Alex Velenko <Alex.Velenko@arm.com>
>>
>> * gcc.target/arm/thumb-ltu.c (foo): Predefined.
>> (bar): Predefined.
>> ---
>> gcc/testsuite/gcc.target/arm/thumb-ltu.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/gcc/testsuite/gcc.target/arm/thumb-ltu.c
>> b/gcc/testsuite/gcc.target/arm/thumb-ltu.c
>> index d057ea3..124b025 100644
>> --- a/gcc/testsuite/gcc.target/arm/thumb-ltu.c
>> +++ b/gcc/testsuite/gcc.target/arm/thumb-ltu.c
>> @@ -2,6 +2,9 @@
>> /* { dg-require-effective-target arm_thumb1_ok } */
>> /* { dg-options "-mcpu=arm1136jf-s -mthumb -O2" } */
>>
>> +int foo();
>> +int bar();
>> +
>
> Surely this is,
>
>
> extern int foo (void);
> extern int bar (void);
>
>> void f(unsigned a, unsigned b, unsigned c, unsigned d)
>> {
>> if (a <= b || c > d)
>>
>
>
> OK with that change.
>
> Ramana
>
Committed with said change r223982.
Is patch ok for fsf-5 backport?
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [PATCH][ARM] Fix thumb-ltu.c testcase.
2015-06-04 12:55 ` Alex Velenko
@ 2015-06-04 13:08 ` Ramana Radhakrishnan
0 siblings, 0 replies; 4+ messages in thread
From: Ramana Radhakrishnan @ 2015-06-04 13:08 UTC (permalink / raw)
To: Alex Velenko, gcc-patches
>>
> Committed with said change r223982.
> Is patch ok for fsf-5 backport?
> Alex
>
OK if no regressions.
Ramana
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-04 12:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-01 9:49 [PATCH] [PATCH][ARM] Fix thumb-ltu.c testcase Alex Velenko
2015-06-01 9:50 ` Ramana Radhakrishnan
2015-06-04 12:55 ` Alex Velenko
2015-06-04 13:08 ` Ramana Radhakrishnan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).