From: Renlin Li <renlin.li@arm.com>
To: Marcus Shawcroft <marcus.shawcroft@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Andrew Pinski <pinskia@gmail.com>
Subject: Re: Re: [PATCH][AARCH64]Add ACLE 2.0 predefined macros: __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR
Date: Thu, 04 Jun 2015 13:59:00 -0000 [thread overview]
Message-ID: <5570544B.8000508@arm.com> (raw)
In-Reply-To: <CAFqB+PwEguYuiAhKPN46TMbTo1gYgTsWnWktNvav7MCTJpxNFA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2252 bytes --]
On 29/04/15 11:58, Marcus Shawcroft wrote:
> On 29 April 2015 at 01:24, Andrew Pinski <pinskia@gmail.com> wrote:
>> On Tue, Dec 16, 2014 at 2:19 AM, Renlin Li <renlin.li@arm.com> wrote:
>>> Hi all,
>>>
>>> This is a simple patch to add another two ACLE 2.0 predefined macros into
>>> aarch64 backend.
>>> They are __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR. Currently, those
>>> two values are hard-wired to 16.
>>>
>>> The following clauses from ACLE 2.0 documentation indicate the meaning of
>>> those two macros:
>>>
>>> The macro __ARM_ALIGN_MAX_STACK_PWR indicates (as the exponent of a power of
>>> 2) the maximum available stack alignment.
>>> The macro __ARM_ALIGN_MAX_PWR indicates (as the exponent of a power of 2)
>>> the maximum available alignment of static data.
>>>
>>> aarch64-none-elf target is tested on on the model. No new regression.
>>>
>>> Is it Okay for trunk?
>> Have you tested these alignments? That is have we tested 65536
>> alignment for both stack and static data?
>> I suspect the stack alignment that is support is not 64k but much
>> smaller. And the supported static data alignment is much larger,
>> maybe 20 or more.
> Looks to me __ARM_ALIGN_MAX_STACK_PWR can be lifted to 2^16 without
> issue. GCC won't gripe about the static data alignment until 2^29.
> Aside from the latter being rather conservative I think we should add
> a test case to the testsuite for each. RenLin can you prep a testcase?
>
> /Marcus
Hi Marcus,
Sorry for the delay. I have come up with an updated patch. Two test
cases are added to check against the limit.
__ARM_ALIGN_MAX_STACK_PWR is hard coded into 16.
__ARM_ALIGN_MAX_PWR is hard coded into 28 which is the maximum
allowable alignment user can define for aarch64 backend.
Okay to commit on trunk, and backport to 5.0?
Regards,
Renlin Li
gcc/ChangeLog:
2015-06-04 Renlin Li <renlin.li@arm.com>
* config/aarch64/aarch64.h (TARGET_CPU_CPP_BUILTINS): Add
__ARM_ALIGN_MAX_PWR,
__ARM_ALIGN_MAX_STACK_PWR.
gcc/testsuite/ChangeLog:
2015-06-04 Renlin Li <renlin.li@arm.com>
* gcc.target/aarch64/arm_align_max_pwr.c: New.
* gcc.target/aarch64/arm_align_max_stack_pwr.c: New.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: tmp(1).diff --]
[-- Type: text/x-patch; name="tmp(1).diff", Size: 1900 bytes --]
diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h
index 25b9927..085148d 100644
--- a/gcc/config/aarch64/aarch64.h
+++ b/gcc/config/aarch64/aarch64.h
@@ -29,6 +29,10 @@
builtin_define ("__aarch64__"); \
builtin_define ("__ARM_64BIT_STATE"); \
builtin_define_with_int_value \
+ ("__ARM_ALIGN_MAX_PWR", 28); \
+ builtin_define_with_int_value \
+ ("__ARM_ALIGN_MAX_STACK_PWR", 16); \
+ builtin_define_with_int_value \
("__ARM_ARCH", aarch64_architecture_version); \
cpp_define_formatted \
(parse_in, "__ARM_ARCH_%dA", aarch64_architecture_version); \
diff --git a/gcc/testsuite/gcc.target/aarch64/arm_align_max_pwr.c b/gcc/testsuite/gcc.target/aarch64/arm_align_max_pwr.c
new file mode 100644
index 0000000..d8471f5
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/arm_align_max_pwr.c
@@ -0,0 +1,15 @@
+/* { dg-do run } */
+
+#include <stdio.h>
+#include <assert.h>
+
+#define align (1ul << __ARM_ALIGN_MAX_PWR)
+static int x __attribute__ ((aligned (align)));
+
+int
+main ()
+{
+ assert ((((unsigned long)&x) & (align - 1)) == 0);
+
+ return 0;
+}
diff --git a/gcc/testsuite/gcc.target/aarch64/arm_align_max_stack_pwr.c b/gcc/testsuite/gcc.target/aarch64/arm_align_max_stack_pwr.c
new file mode 100644
index 0000000..e2e7900
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/arm_align_max_stack_pwr.c
@@ -0,0 +1,15 @@
+/* { dg-do run } */
+
+#include <stdio.h>
+#include <assert.h>
+
+#define align (1ul << __ARM_ALIGN_MAX_STACK_PWR)
+
+int
+main ()
+{
+ int x __attribute__ ((aligned (align)));
+
+ assert ((((unsigned long)&x) & (align - 1)) == 0);
+ return 0;
+}
next prev parent reply other threads:[~2015-06-04 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 10:24 Renlin Li
2015-04-28 16:01 ` [PING][PATCH][AARCH64]Add " Renlin Li
2015-04-28 17:04 ` [PATCH][AARCH64]Add " Marcus Shawcroft
2015-04-29 1:25 ` Andrew Pinski
2015-04-29 11:14 ` Marcus Shawcroft
2015-06-04 13:59 ` Renlin Li [this message]
2015-06-11 10:56 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5570544B.8000508@arm.com \
--to=renlin.li@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marcus.shawcroft@gmail.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).