From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123681 invoked by alias); 4 Jun 2015 15:29:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 123666 invoked by uid 89); 4 Jun 2015 15:29:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jun 2015 15:29:42 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-5.uk.mimecast.lan; Thu, 04 Jun 2015 16:29:39 +0100 Received: from [10.2.207.43] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 4 Jun 2015 16:29:39 +0100 Message-ID: <55706EE3.1090709@arm.com> Date: Thu, 04 Jun 2015 15:53:00 -0000 From: Renlin Li User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jonathan Wakely CC: "gcc-patches@gcc.gnu.org" , "libstdc++@gcc.gnu.org" , Marcus Shawcroft Subject: Re: [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc References: <5549CC2E.2060605@arm.com> <20150601155854.GD17401@redhat.com> In-Reply-To: <20150601155854.GD17401@redhat.com> X-MC-Unique: IQNQ5MzSSvaqTy9vajZXSg-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00422.txt.bz2 Hi Jonathan, I have committed it on trunk. Is it Okay for me to backport it to branch 5.0, 4.9 to remove failing noise? Regards, Renlin Li On 01/06/15 16:58, Jonathan Wakely wrote: > On 06/05/15 09:09 +0100, Renlin Li wrote: >> Hi all, >> >> This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the tes= t. >> >> In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit() >> function is nullified when either _GLIBCXX_RES_LIMITS or >> _GLIBCXX_HAVE_LIMIT_FSIZE is not defined. >> _GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however, >> _GLIBCXX_HAVE_LIMIT_FSIZE is not checked. >> >> The complete condition for correct execution of this test case is >> that, those two macros are both defined. >> >> Is Okay to commit? > OK. > >> Regards, >> Renlin Li >> >> libstdc++-v3/ChangeLog: >> >> 2015-05-06 Renlin Li >> >> * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check. >> diff --git a/libstdc++-v3/testsuite/27_io/fpos/14775.cc b/libstdc++-v3/t= estsuite/27_io/fpos/14775.cc >> index b700868..69c0a6a 100644 >> --- a/libstdc++-v3/testsuite/27_io/fpos/14775.cc >> +++ b/libstdc++-v3/testsuite/27_io/fpos/14775.cc >> @@ -27,7 +27,7 @@ >> // Basic test for LFS support. >> void test01() >> { >> -#ifdef _GLIBCXX_USE_LFS >> +#if defined (_GLIBCXX_USE_LFS) && defined (_GLIBCXX_HAVE_LIMIT_FSIZE) >> using namespace std; >> bool test __attribute__((unused)) =3D true; >>