From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52399 invoked by alias); 5 Jun 2015 16:54:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 51770 invoked by uid 89); 5 Jun 2015 16:54:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 05 Jun 2015 16:54:34 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B37A536B382; Fri, 5 Jun 2015 16:54:32 +0000 (UTC) Received: from [10.10.116.25] ([10.10.116.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t55GsVc3024489; Fri, 5 Jun 2015 12:54:32 -0400 Message-ID: <5571D443.2000603@redhat.com> Date: Fri, 05 Jun 2015 17:05:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Aldy Hernandez , Richard Biener CC: gcc-patches Subject: Re: [debug-early] fix problem with template parameter packs References: <55482AF6.1090207@redhat.com> <5549314D.6080804@redhat.com> <5549373F.6020503@redhat.com> <554A4146.4010501@redhat.com> <5564A158.8010604@redhat.com> <55661C58.6040305@redhat.com> <556EFB62.3040209@redhat.com> <556F1256.1030400@redhat.com> <557097BB.4080709@redhat.com> <55709B60.7050004@redhat.com> <5570DFBA.9080407@redhat.com> <5571ABED.8090808@redhat.com> <5571B904.3090609@redhat.com> <5571CC3D.6010805@redhat.com> <5571CF76.2040606@redhat.com> In-Reply-To: <5571CF76.2040606@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00472.txt.bz2 On 06/05/2015 12:33 PM, Aldy Hernandez wrote: > + /* The tree for which this DIE was created for. We use this to Too many "for"s. > - fprintf (outfile, "DIE %4ld: %s (%p)\n", > + fprintf (outfile, "DIE %4ld: %s (%p)", > die->die_offset, dwarf_tag_name (die->die_tag), > (void*) die); > + fputc ('\n', outfile); I don't think you need this change. > else if (declaration) > - gen_formal_types_die (decl, subr_die); > + { > + /* Only generate a prototype's parameters once. */ > + if (!old_die) > + gen_formal_types_die (decl, subr_die); > + } I think this is dead code now, since you return early if declaration && old_die. OK with those changes. Jason