From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49710 invoked by alias); 6 Jun 2015 10:23:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 49690 invoked by uid 89); 6 Jun 2015 10:23:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout2.netcologne.de Received: from cc-smtpout2.netcologne.de (HELO cc-smtpout2.netcologne.de) (89.1.8.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 06 Jun 2015 10:23:04 +0000 Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout2.netcologne.de (Postfix) with ESMTP id BD8141208D; Sat, 6 Jun 2015 12:22:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin3.netcologne.de (Postfix) with ESMTP id B146611DEE; Sat, 6 Jun 2015 12:22:59 +0200 (CEST) Received: from [78.35.163.62] (helo=cc-smtpin3.netcologne.de) by localhost with ESMTP (eXpurgate 4.0.7) (envelope-from ) id 5572ca03-0b62-7f0000012729-7f000001a557-1 for ; Sat, 06 Jun 2015 12:22:59 +0200 Received: from [192.168.178.20] (xdsl-78-35-163-62.netcologne.de [78.35.163.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA; Sat, 6 Jun 2015 12:22:57 +0200 (CEST) Message-ID: <5572CA00.3020005@netcologne.de> Date: Sat, 06 Jun 2015 11:35:00 -0000 From: Thomas Koenig User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Steve Kargl CC: "fortran@gcc.gnu.org" , gcc-patches Subject: Re: [patch, fortran] PR 47359 - warnings for constant conversion References: <556B7ED1.4020304@netcologne.de> <20150531221425.GA34602@troutmask.apl.washington.edu> <556BFCF0.5030607@netcologne.de> <20150601134017.GA37949@troutmask.apl.washington.edu> <556C9E11.4090502@netcologne.de> <20150601201048.GA43914@troutmask.apl.washington.edu> In-Reply-To: <20150601201048.GA43914@troutmask.apl.washington.edu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00501.txt.bz2 Am 01.06.2015 um 22:10 schrieb Steve Kargl: >> c) Warn for >> >> print *,3.1415926535 with -Wconversion-extra >> >> and don't warn for >> >> print *,3.141592653589_4 >> > > This would be my first choice. If a user actually specifies > a suffix, I assume that the user has given some thought > to the preceding digits. >> d) Like now: Warn with -Wconversion-extra for both >> >> print *,3.1415926535 >> >> and >> >> print *,3.14159265358979_4 > > This would be my second choice. I would actually prefer d). -Wconversion-extra is about warning for things that are often correct. I would like to have a chance to warn about this kind of construct. Any other comments? OK to commit? Thomas