From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128117 invoked by alias); 8 Jun 2015 09:26:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128107 invoked by uid 89); 8 Jun 2015 09:26:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jun 2015 09:26:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CE2C29; Mon, 8 Jun 2015 02:26:50 -0700 (PDT) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 43F723F32C; Mon, 8 Jun 2015 02:26:40 -0700 (PDT) Message-ID: <55755FCF.8010706@foss.arm.com> Date: Mon, 08 Jun 2015 09:33:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Christian Bruel , Kyrill Tkachov , Ramana Radhakrishnan , Sandra Loosemore CC: "gcc-patches@gcc.gnu.org" , Richard Earnshaw , "nickc@redhat.com" Subject: Re: [PATCH, ARM] attribute target (thumb,arm) [4/6] respin (5th) References: <554A243B.8010902@st.com> <554A9DB1.1070009@codesourcery.com> <554C7459.4000806@arm.com> <55599F54.4040807@st.com> <556C366B.8000203@arm.com> <556C4235.5060203@st.com> <556C530B.8000105@arm.com> <55755277.5070005@st.com> In-Reply-To: <55755277.5070005@st.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00541.txt.bz2 On 08/06/15 09:45, Christian Bruel wrote: > Hi Ramana, > >> >> Ok, I see. >> The patch looks ok to me modulo the typo nits I pointed out, but I >> think Ramana >> should have the final say here as he's already started reviewing it >> and it adds quite >> a lot of functionality. >> >> Thanks, >> Kyrill >> > > do you have other feedbacks for the remaining parts ? > > many thanks > > Christian This is OK, thanks. Ramana