From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91869 invoked by alias); 8 Jun 2015 10:23:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 91851 invoked by uid 89); 8 Jun 2015 10:23:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Jun 2015 10:23:41 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id CF2F8B1FAE; Mon, 8 Jun 2015 10:23:39 +0000 (UTC) Received: from reynosa.quesejoda.com (vpn-60-44.rdu2.redhat.com [10.10.60.44]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t58ANces007279; Mon, 8 Jun 2015 06:23:38 -0400 Message-ID: <55756D29.2040009@redhat.com> Date: Mon, 08 Jun 2015 10:27:00 -0000 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Iain Sandoe CC: Andreas Schwab , GCC Mailing List , Mike Stump , gcc-patches Subject: Re: [patch] fix _OBJC_Module defined but not used warning References: <5571F319.205@redhat.com> <55742CFB.2060209@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00546.txt.bz2 On 06/08/2015 04:03 AM, Iain Sandoe wrote: > Hi Aldy, > > On 7 Jun 2015, at 12:37, Aldy Hernandez wrote: > >> On 06/07/2015 06:19 AM, Andreas Schwab wrote: >>> Another fallout: >>> >>> FAIL: obj-c++.dg/try-catch-5.mm -fgnu-runtime (test for excess errors) >>> Excess errors: >>> : warning: '_OBJC_Module' defined but not used [-Wunused-variable] >> >> check_global_declarations is called for more symbols now. All the defined but not used errors I've seen in development have been legitimate. For tests, the tests should be fixed. For built-ins such as these, does the attached fix the problem? >> >> It is up to the objc maintainers, we can either fix this with the attached patch, > > The current patch is OK. Committed. > >> or setting DECL_IN_SYSTEM_HEADER. > > This seems a better long-term idea; however, I would prefer to go through all the cases where it would be applicable (including for the NeXT runtime) and apply that change as a coherent patch. At the moment dealing with the NeXT stuff is a bit hampered by pr66448. On my list next. Aldy