From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73059 invoked by alias); 8 Jun 2015 13:33:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 72980 invoked by uid 89); 8 Jun 2015 13:33:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e06smtp11.uk.ibm.com Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 08 Jun 2015 13:32:58 +0000 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Jun 2015 14:32:54 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 8 Jun 2015 14:32:52 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id BB1EC17D8059 for ; Mon, 8 Jun 2015 14:33:52 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t58DWpwM22675690 for ; Mon, 8 Jun 2015 13:32:51 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t58DWpmt011831 for ; Mon, 8 Jun 2015 07:32:51 -0600 Received: from [9.152.212.139] (dyn-9-152-212-139.boeblingen.de.ibm.com [9.152.212.139]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t58DWpPh011814; Mon, 8 Jun 2015 07:32:51 -0600 Message-ID: <55759982.4090402@linux.vnet.ibm.com> Date: Mon, 08 Jun 2015 13:35:00 -0000 From: Andreas Krebbel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jakub Jelinek CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 01/13] recog: Increased max number of alternatives - v2 References: <1431350621-21405-1-git-send-email-krebbel@linux.vnet.ibm.com> <1431350621-21405-2-git-send-email-krebbel@linux.vnet.ibm.com> <5559EBF8.3050003@linux.vnet.ibm.com> <555AF6FA.4040408@linux.vnet.ibm.com> <20150522075400.GA17341@maggie> <20150601082201.GG10247@tucnak.redhat.com> In-Reply-To: <20150601082201.GG10247@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15060813-0041-0000-0000-000004B29486 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00564.txt.bz2 On 06/01/2015 10:22 AM, Jakub Jelinek wrote: > On Fri, May 22, 2015 at 09:54:00AM +0200, Andreas Krebbel wrote: >> On Tue, May 19, 2015 at 10:40:26AM +0200, Andreas Krebbel wrote: >>> On 05/18/2015 04:19 PM, Richard Biener wrote: >>>> Please use uint64_t instead. >>> >>> Done. Ok with that change? >> >> I've applied the following patch. > > Note that on current trunk cross compiler from x86_64-linux to > s390x-linux (admittedly just make cc1 of an older configured tree, > but with libcpp (normal and build) rebuilt) fails miserably with > genattrtab: invalid alternative specified for pattern number 1015 > >> * recog.h: Increase MAX_RECOG_ALTERNATIVES. >> Change type of alternative_mask to uint64_t. > > From quick look at genattrtab.c, there are many further spots > which rely on MAX_RECOG_ALTERNATIVES fitting into int bits. > > With this quick patch make cc1 at least succeeds, but no idea whether > I've caught all the spots which work with bitmasks of alternatives. I've regtested your patch on S/390 without seeing any problems. Could you please commit it to mainline? Thanks! Bye, -Andreas-