From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94095 invoked by alias); 8 Jun 2015 15:59:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 94077 invoked by uid 89); 8 Jun 2015 15:59:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Jun 2015 15:59:48 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 60AE3B5996; Mon, 8 Jun 2015 15:59:47 +0000 (UTC) Received: from [10.10.48.226] (vpn-48-226.rdu2.redhat.com [10.10.48.226]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t58Fxk5b013182; Mon, 8 Jun 2015 11:59:46 -0400 Message-ID: <5575BBF1.8080704@redhat.com> Date: Mon, 08 Jun 2015 16:01:00 -0000 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jonathan Wakely , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [patch] libstdc++/66030 fix codecvt exports for mingw32 References: <20150608151218.GY12728@redhat.com> In-Reply-To: <20150608151218.GY12728@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00598.txt.bz2 On 06/08/2015 09:12 AM, Jonathan Wakely wrote: > The linker script assumes that std::mbstate_t has the name __mbstate_t > for linkage purposes, but that's not necessarily true. For mingw32 > it's just a typedef for int, so the patterns don't match. > > This adds a new mingw32-specific pattern for codecvt_byname's > constructors and destructors, and relaxes the patterns for > codecvt so they match __mbstate_t or int. As a data point, in case other targets have a similar issue, mbstate_t is a typedef for char* on AIX, and (based on my old notes) typedef struct mbstate_t on HP-UX. (It is a typedef struct __mbstate_t on Darwin and Solaris.) Martin