Re: [PATCH, ARM] attribute target (thumb,arm) [6/6] respin (5th)

[Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>]

Hi Christian,


On 18/05/15 09:41, Christian Bruel wrote:
> On 05/06/2015 04:29 PM, Christian Bruel wrote:
>> >Implement the -mflip-thump option. Undocumented for internal testing
>> >only. This option artificially inserts alternative attribute thumb/modes
>> >on functions.
>> >
>> >This close the patch set. Thanks for your review,
>> >
>> >Christian
>> >
> to close the series. redo patch rebased.
>   

<snip>

>   static bool
> diff '--exclude=.svn' -ruN gnu_trunk.p5/gcc/gcc/config/arm/arm.opt gnu_trunk.p6/gcc/gcc/config/arm/arm.opt
> --- gnu_trunk.p5/gcc/gcc/config/arm/arm.opt	2015-05-18 10:20:26.545835080 +0200
> +++ gnu_trunk.p6/gcc/gcc/config/arm/arm.opt	2015-05-13 13:13:11.014686529 +0200
> @@ -122,6 +122,10 @@
>   EnumValue
>   Enum(float_abi_type) String(hard) Value(ARM_FLOAT_ABI_HARD)
>   
> +mflip-thumb
> +Target Report Var(TARGET_FLIP_THUMB)
> +Switch ARM/Thumb modes on alternating functions for compiler testing

How about adding 'Undocumented' to the properties here?

Can we also get a test or two just to sanity check the option?
Otherwise the patch looks ok to me.

Thanks,
Kyrill