From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10001 invoked by alias); 9 Jun 2015 10:04:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9991 invoked by uid 89); 9 Jun 2015 10:04:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Jun 2015 10:04:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 954D029; Tue, 9 Jun 2015 03:04:56 -0700 (PDT) Received: from [10.2.207.50] (e100706-lin.cambridge.arm.com [10.2.207.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5151C3F32C; Tue, 9 Jun 2015 03:04:46 -0700 (PDT) Message-ID: <5576BA3C.2020101@foss.arm.com> Date: Tue, 09 Jun 2015 10:08:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Christian Bruel , "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan Subject: Re: [PATCH, ARM] attribute target (thumb,arm) [6/6] respin (5th) References: <554A253A.4080905@st.com> <5559A5B4.7050007@st.com> In-Reply-To: <5559A5B4.7050007@st.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00643.txt.bz2 Hi Christian, On 18/05/15 09:41, Christian Bruel wrote: > On 05/06/2015 04:29 PM, Christian Bruel wrote: >> >Implement the -mflip-thump option. Undocumented for internal testing >> >only. This option artificially inserts alternative attribute thumb/modes >> >on functions. >> > >> >This close the patch set. Thanks for your review, >> > >> >Christian >> > > to close the series. redo patch rebased. > > static bool > diff '--exclude=.svn' -ruN gnu_trunk.p5/gcc/gcc/config/arm/arm.opt gnu_trunk.p6/gcc/gcc/config/arm/arm.opt > --- gnu_trunk.p5/gcc/gcc/config/arm/arm.opt 2015-05-18 10:20:26.545835080 +0200 > +++ gnu_trunk.p6/gcc/gcc/config/arm/arm.opt 2015-05-13 13:13:11.014686529 +0200 > @@ -122,6 +122,10 @@ > EnumValue > Enum(float_abi_type) String(hard) Value(ARM_FLOAT_ABI_HARD) > > +mflip-thumb > +Target Report Var(TARGET_FLIP_THUMB) > +Switch ARM/Thumb modes on alternating functions for compiler testing How about adding 'Undocumented' to the properties here? Can we also get a test or two just to sanity check the option? Otherwise the patch looks ok to me. Thanks, Kyrill