From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2231 invoked by alias); 9 Jun 2015 10:27:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2219 invoked by uid 89); 9 Jun 2015 10:27:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mx07-00178001.pphosted.com Received: from mx07-00178001.pphosted.com (HELO mx07-00178001.pphosted.com) (62.209.51.94) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 09 Jun 2015 10:27:55 +0000 Received: from pps.filterd (m0046670.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.14.5/8.14.5) with SMTP id t59AIFJD011881; Tue, 9 Jun 2015 12:27:48 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 1uun8dg0es-1 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 09 Jun 2015 12:27:48 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2FFA031; Tue, 9 Jun 2015 10:27:42 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas1.st.com [10.75.90.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D9FD72D2D; Tue, 9 Jun 2015 10:27:42 +0000 (GMT) Received: from [164.129.122.197] (164.129.122.197) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.342.0; Tue, 9 Jun 2015 12:27:42 +0200 Message-ID: <5576BF9E.60000@st.com> Date: Tue, 09 Jun 2015 10:40:00 -0000 From: Christian Bruel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Kyrill Tkachov , "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan Subject: Re: [PATCH, ARM] attribute target (thumb,arm) [6/6] respin (5th) References: <554A253A.4080905@st.com> <5559A5B4.7050007@st.com> <5576BA3C.2020101@foss.arm.com> In-Reply-To: <5576BA3C.2020101@foss.arm.com> X-No-Archive: yes Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-06-09_09:2015-06-08,2015-06-09,1970-01-01 signatures=0 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00645.txt.bz2 On 06/09/2015 12:04 PM, Kyrill Tkachov wrote: > Hi Christian, > > > On 18/05/15 09:41, Christian Bruel wrote: >> On 05/06/2015 04:29 PM, Christian Bruel wrote: >>>> Implement the -mflip-thump option. Undocumented for internal testing >>>> only. This option artificially inserts alternative attribute thumb/modes >>>> on functions. >>>> >>>> This close the patch set. Thanks for your review, >>>> >>>> Christian >>>> >> to close the series. redo patch rebased. >> > > > >> static bool >> diff '--exclude=.svn' -ruN gnu_trunk.p5/gcc/gcc/config/arm/arm.opt gnu_trunk.p6/gcc/gcc/config/arm/arm.opt >> --- gnu_trunk.p5/gcc/gcc/config/arm/arm.opt 2015-05-18 10:20:26.545835080 +0200 >> +++ gnu_trunk.p6/gcc/gcc/config/arm/arm.opt 2015-05-13 13:13:11.014686529 +0200 >> @@ -122,6 +122,10 @@ >> EnumValue >> Enum(float_abi_type) String(hard) Value(ARM_FLOAT_ABI_HARD) >> >> +mflip-thumb >> +Target Report Var(TARGET_FLIP_THUMB) >> +Switch ARM/Thumb modes on alternating functions for compiler testing > > How about adding 'Undocumented' to the properties here? OK, > > Can we also get a test or two just to sanity check the option? sure, I have on stage a few chunks to improve the testsuite score with this option. I will pass on a -mflip option sanity check in the same review. > Otherwise the patch looks ok to me. > many thanks, Christian > Thanks, > Kyrill >