On 09/06/15 13:07, Richard Biener wrote: > On Mon, 8 Jun 2015, Tom de Vries wrote: > >> On 17/04/15 12:08, Tom de Vries wrote: >>> On 20-03-15 12:38, Tom de Vries wrote: >>>> On 19-03-15 12:05, Tom de Vries wrote: >>>>> On 18-03-15 18:22, Tom de Vries wrote: >>>>>> Hi, >>>>>> >>>>>> this patch fixes PR65460. >>>>>> >>>>>> The patch marks offloaded functions as parallelized, which means the >>>>>> parloops >>>>>> pass no longer attempts to modify that function. >>>>> >>>>> Updated patch to postpone mark_parallelized_function until the >>>>> corresponding >>>>> cgraph_node is available, to ensure it works with the updated >>>>> mark_parallelized_function from patch 2/3. >>>>> >>>> >>>> Updated to eliminate mark_parallelized_function. >>>> >>>> Bootstrapped and reg-tested on x86_64. >>>> >>>> OK for stage4? >>>> >>> >>> ping. >> >> ping^2. Original post at >> https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01063.html . > > Ok, but shouldn't it be set before calling add_new_function as > add_new_function might run passes that wouldn't identify the > function as parallelized? > Hm, indeed sometimes add_new_function executes some passes itself, besides queueing the function for further processing. I suppose the existing settings of parallelized_function should be modified in a similar way. I'll bootstrap and reg-test attached two patches on x86_64, and commit unless objections. Thanks, - Tom