public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Koenig <tkoenig@netcologne.de>
To: Andre Vehreschild <vehre@gmx.de>,
	 GCC-Patches-ML <gcc-patches@gcc.gnu.org>,
	GCC-Fortran-ML <fortran@gcc.gnu.org>
Subject: Re: [Patch, fortran, PR44672, v10] [F08] ALLOCATE with SOURCE and no array-spec
Date: Thu, 11 Jun 2015 22:05:00 -0000	[thread overview]
Message-ID: <557A04D4.8050404@netcologne.de> (raw)
In-Reply-To: <20150610102627.1353bbd9@vepi2>

Hi Andre,

> please find attached an updated version of the patch. This patch simplifies
> some cases and ensures more straight line code. Furthermore was a bug in the
> interfacing routine for the _vptr->_copy() routine removed, where not the third
> and fourth arguments translated to be passed be value but the fourth and fifth
> (cs start counting at zero...).
> 
> Bootstraps and regtests fine on x86_64-linux-gnu/f21.
> 
> Ok for trunk?

Following the discussions, and looking through the patch, I would say
this patch is in pretty good shape (and quite impressive, too).

My vote would be to commit as is, unless something important comes up,
and fix smaller problems and possible corner cases afterwards, if any
exist.  However, I am not really deep into these aspects of the
compiler, and I would still like to leave some time for others to
comment if they think this is appropriate.

So, OK to commit in two days unless there are objections.

Thanks for the patch!

	Thomas

  reply	other threads:[~2015-06-11 21:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 17:48 [Patch, fortran, PR44672, v1] " Andre Vehreschild
2015-04-01 13:15 ` [Patch, fortran, PR44672, v2] " Andre Vehreschild
2015-04-02  9:03   ` [Patch, fortran, PR44672, v3] " Andre Vehreschild
2015-04-23 12:45     ` [Ping, Patch, " Andre Vehreschild
2015-04-29 15:29       ` [Patch, fortran, PR44672, v4] " Andre Vehreschild
2015-04-30 14:31         ` [Patch, fortran, PR44672, v5] " Andre Vehreschild
2015-05-19 10:29           ` [Patch, fortran, PR44672, v6] " Andre Vehreschild
2015-05-22 10:24             ` Ping: " Andre Vehreschild
2015-05-25 19:35             ` Mikael Morin
2015-05-28 15:48               ` Andre Vehreschild
2015-05-28 18:42                 ` Mikael Morin
2015-05-29 12:41                   ` Andre Vehreschild
2015-05-30  4:23                     ` Thomas Koenig
2015-06-02 16:52                     ` Mikael Morin
2015-06-03 15:25                       ` Andre Vehreschild
2015-06-05 12:04                         ` [Patch, fortran, PR44672, v9] " Andre Vehreschild
2015-06-09  5:36                           ` Damian Rouson
2015-06-10  8:59                           ` [Patch, fortran, PR44672, v10] " Andre Vehreschild
2015-06-11 22:05                             ` Thomas Koenig [this message]
2015-06-12  8:00                               ` Andre Vehreschild
2015-06-15 10:43                               ` Andre Vehreschild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557A04D4.8050404@netcologne.de \
    --to=tkoenig@netcologne.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=vehre@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).