public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: jason merrill <jason@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] fix darwin bootstrap by avoiding duplicate DIE attributes
Date: Fri, 12 Jun 2015 13:46:00 -0000	[thread overview]
Message-ID: <557AE21C.9050902@redhat.com> (raw)
In-Reply-To: <874mmdxuft.fsf@igel.home>

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

On 06/12/2015 12:22 AM, Andreas Schwab wrote:
> ../../gcc/dwarf2out.c:5693:1: error: 'void check_die(dw_die_ref)' defined but not used [-Werror=unused-function]
>
> Andreas.
>

Committed as obvious.

[-- Attachment #2: curr --]
[-- Type: text/plain, Size: 749 bytes --]

commit 76da2378b15ad786e8c2c64ddd8b39c132947738
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Fri Jun 12 06:42:08 2015 -0700

    	* dwarf2out.c (check_die): Protect with ENABLE_CHECKING.

diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index 92fa340..d2c516a 100644
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -5687,6 +5687,7 @@ debug_dwarf (void)
   print_die (comp_unit_die (), stderr);
 }
 
+#ifdef ENABLE_CHECKING
 /* Sanity checks on DIEs.  */
 
 static void
@@ -5749,6 +5750,7 @@ check_die (dw_die_ref die)
 		    && a->dw_attr != DW_AT_GNU_all_call_sites);
     }
 }
+#endif
 \f
 /* Start a new compilation unit DIE for an include file.  OLD_UNIT is the CU
    for the enclosing include file, if any.  BINCL_DIE is the DW_TAG_GNU_BINCL

      reply	other threads:[~2015-06-12 13:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 14:07 Aldy Hernandez
2015-06-11 20:40 ` Aldy Hernandez
2015-06-11 20:45   ` Jason Merrill
2015-06-12  7:56   ` Andreas Schwab
2015-06-12 13:46     ` Aldy Hernandez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557AE21C.9050902@redhat.com \
    --to=aldyh@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).