From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101332 invoked by alias); 16 Jun 2015 09:06:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 101323 invoked by uid 89); 16 Jun 2015 09:06:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jun 2015 09:06:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C57792A; Tue, 16 Jun 2015 02:06:17 -0700 (PDT) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A6C53F447; Tue, 16 Jun 2015 02:06:01 -0700 (PDT) Message-ID: <557FE6FA.9020803@foss.arm.com> Date: Tue, 16 Jun 2015 09:07:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Eric Botcazou , gcc-patches@gcc.gnu.org Subject: Re: [patch 2/6] scalar-storage-order merge: C front-end References: <3247494.5bgQPARZRk@polaris> <2396877.AqT21tpnmO@polaris> In-Reply-To: <2396877.AqT21tpnmO@polaris> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01086.txt.bz2 On 16/06/15 09:54, Eric Botcazou wrote: > This is the C front-end + C family part. > > * doc/extend.texi (type attributes): Document scalar_storage_order. > * doc/invoke.texi (Warnings): Document -Wno-scalar-storage-order. > c-family/ > * c-common.c (c_common_attributes): Add scalar_storage_order. > (handle_scalar_storage_order_attribute): New function. > * c.opt (Wscalar-storage-order): New warning. > c/ > * c-decl.c (finish_struct): If the structure has reverse scalar storage > order, rewrite the type of array fields with scalar component. > * c-typeck.c (build_unary_op) : Remove left-overs. Issue > errors on bit-fields and reverse SSO here and not... > (c_mark_addressable): ...here. > > doc/extend.texi | 47 +++++++++++++++++++++++++++++++++++++++++++++ > doc/invoke.texi | 6 +++++ > c-family/c.opt | 4 +++ > c-family/c-common.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++- > c/c-typeck.c | 53 +++++++++++++++++++++++++++++++------------------- > c/c-decl.c | 45 +++++++++++++++++++++++++++++-------------- > 6 files changed, 175 insertions(+), 34 deletions(-) > A very cursory glance at the patch set but should we restrict this attribute to apply only to scalar types rather than allow them on vector extensions. I haven't had enough coffee this morning but a first thought is that if it does apply on vector type extensions, clarifying the lane ordering up front would be helpful especially as we now allow indexing into short vectors. regards Ramana