From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67003 invoked by alias); 6 Jun 2016 17:57:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 66990 invoked by uid 89); 6 Jun 2016 17:57:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 06 Jun 2016 17:57:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 48A94778; Mon, 6 Jun 2016 17:56:59 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-3.phx2.redhat.com [10.3.116.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u56HuwMr017177; Mon, 6 Jun 2016 13:56:59 -0400 Subject: Re: [PATCH][vectorizer] Remove blank debug lines after dump_gimple_stmt To: Alan Hayward , "gcc-patches@gcc.gnu.org" References: From: Jeff Law Message-ID: <557dd68a-eb64-a798-2ac4-2a3596a3c951@redhat.com> Date: Mon, 06 Jun 2016 17:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00414.txt.bz2 On 06/06/2016 06:46 AM, Alan Hayward wrote: > Lots of code calls dump_gimple_stmt then print a newline, however > dump_gimple_stmt will print a newline itself. This makes the vectorizer > debug > file messy. I think the confusion is because dump_generic_expr does NOT > print a > newline. This patch removes all prints of a newline direcly after a > dump_gimple_stmt. > > Tested by examining a selection of vect dump files. > > gcc/ > \* tree-vect-data-refs.c (vect_analyze_data_refs): Remove debug newline. > \* tree-vect-loop-manip.c (slpeel_make_loop_iterate_ntimes): likewise. > (vect_can_advance_ivs_p): likewise. > (vect_update_ivs_after_vectorizer): likewise. > \* tree-vect-loop.c (vect_determine_vectorization_factor): likewise. > (vect_analyze_scalar_cycles_1): likewise. > (vect_analyze_loop_operations): likewise. > (report_vect_op): likewise. > (vect_is_slp_reduction): likewise. > (vect_is_simple_reduction): likewise. > (get_initial_def_for_induction): likewise. > (vect_transform_loop): likewise. > \* tree-vect-patterns.c (vect_recog_dot_prod_pattern): likewise. > (vect_recog_sad_pattern): likewise. > (vect_recog_widen_sum_pattern): likewise. > (vect_recog_widening_pattern): likewise. > (vect_recog_divmod_pattern): likewise. > \* tree-vect-slp.c (vect-build-slp_tree_1): likewise. > (vect_analyze_slp_instance): likewise. > (vect_transform_slp_perm_load): likewise. > (vect_schedule_slp_instance): likewise. Wouldn't you also need to verify that the testsuite passes since it could potentially have tests which assume the extra newlines in the test's regexps? So I'm fine with this patch once the testsuite has been verified to run without regressions on a target which exercises the vectorizer. jeff