public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nicholas Clifton <nickc@redhat.com>
To: Jeff Law <law@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: RFA: Fix isl-ast-gen-if-1.c test
Date: Mon, 22 Jun 2015 16:08:00 -0000	[thread overview]
Message-ID: <558832C1.4030109@redhat.com> (raw)
In-Reply-To: <55882C9C.9060405@redhat.com>

Hi Jeff,

> I'd tend to prefer to change the size of the array -- adding another
> conditional in the loop may have unintended consequences that possibly
> scramble things just enough to compromise the test.

Okey dokey, here is a revised version.  Is this one OK ?

Cheers
   Nick

gcc/ChangeLog

Index: 2015-06-22  Nick Clifton  <nickc@redhat.com>

	* gcc.dg/graphite/isl-ast-gen-if.c (main): Increase size of a
	array to allow a[50] to be a valid location.

gcc/testsuite/gcc.dg/graphite/isl-ast-gen-if-1.c
===================================================================
--- gcc/testsuite/gcc.dg/graphite/isl-ast-gen-if-1.c	(revision 224722)
+++ gcc/testsuite/gcc.dg/graphite/isl-ast-gen-if-1.c	(working copy)
@@ -28,7 +28,7 @@
  int
  main (void)
  {
-  int a[50];
+  int a[51]; /* NB This size allows foo's first iteration to write to 
a[50].  */
    foo (a, 50);
    int res = array_sum (a);
    if (res != 49)

  reply	other threads:[~2015-06-22 16:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 15:39 Nick Clifton
2015-06-22 15:41 ` Jeff Law
2015-06-22 16:08   ` Nicholas Clifton [this message]
2015-06-22 16:20     ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558832C1.4030109@redhat.com \
    --to=nickc@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).