From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99250 invoked by alias); 22 Jun 2015 16:07:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99237 invoked by uid 89); 22 Jun 2015 16:07:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 22 Jun 2015 16:07:32 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2E11E36B1A5 for ; Mon, 22 Jun 2015 16:07:31 +0000 (UTC) Received: from [10.36.6.100] (vpn1-6-100.ams2.redhat.com [10.36.6.100]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5MG7T6o003203 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Jun 2015 12:07:30 -0400 Message-ID: <558832C1.4030109@redhat.com> Date: Mon, 22 Jun 2015 16:08:00 -0000 From: Nicholas Clifton User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jeff Law , gcc-patches@gcc.gnu.org Subject: Re: RFA: Fix isl-ast-gen-if-1.c test References: <87r3p3sqh6.fsf@redhat.com> <55882C9C.9060405@redhat.com> In-Reply-To: <55882C9C.9060405@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01456.txt.bz2 Hi Jeff, > I'd tend to prefer to change the size of the array -- adding another > conditional in the loop may have unintended consequences that possibly > scramble things just enough to compromise the test. Okey dokey, here is a revised version. Is this one OK ? Cheers Nick gcc/ChangeLog Index: 2015-06-22 Nick Clifton * gcc.dg/graphite/isl-ast-gen-if.c (main): Increase size of a array to allow a[50] to be a valid location. gcc/testsuite/gcc.dg/graphite/isl-ast-gen-if-1.c =================================================================== --- gcc/testsuite/gcc.dg/graphite/isl-ast-gen-if-1.c (revision 224722) +++ gcc/testsuite/gcc.dg/graphite/isl-ast-gen-if-1.c (working copy) @@ -28,7 +28,7 @@ int main (void) { - int a[50]; + int a[51]; /* NB This size allows foo's first iteration to write to a[50]. */ foo (a, 50); int res = array_sum (a); if (res != 49)